PR#35: Restrict package path comparison for skip self - golist

golist

#35 Restrict package path comparison for skip self

Opened 6 months ago by jackyzy823. Modified 6 months ago

jackyzy823/golist issue34 into master

Restrict package path comparison for skip self

jackyzy823 • 6 months ago

dc7af86

pkg/util/util.go

file modified

+1 -1

		`@@ -327,7 +327,7 @@`
		`var pkgs []string`

		`for relPath := range imports {`
		`- if skipSelf && strings.HasPrefix(relPath, p.packagePath) {`
		`+ if skipSelf && strings.HasPrefix(relPath, p.packagePath+"/") {`
		`continue`
		`}`

jackyzy823 commented 6 months ago

Fix for issue 34

I also encounter this problem when packaging gopass, it depends on "github.com/gopasspw/gopass-hibp/pkg/hibp/api" in github.com/gopasspw/gopass/internal/audit/audit.go , but golist do not generate requires for it .Because "github.com/gopasspw/gopass-hibp" has same prefix with "github.com/gopasspw/gopass".

So we must add a "/" to "github.com/gopasspw/gopass" to prevent the path comparison problem.

Metadata

Assignee

None

Tags

No Tags

Changes Summary 1

+1 -1

file changed

pkg/util/util.go

golist

Source Code

#35 Restrict package path comparison for skip self Opened 6 months ago by jackyzy823. Modified 6 months ago jackyzy823/golist issue34 into master

Metadata

Changes Summary 1

#35 Restrict package path comparison for skip self

Opened 6 months ago by jackyzy823. Modified 6 months ago

jackyzy823/golist issue34 into master