#3 golist needs a switch to process a codebase and its tests in a single pass
Closed: Fixed 3 years ago by qulogic. Opened 3 years ago by nim.

Right now golist does not permit querying the imports of a project and its tests in a single pass. You can emulate most of it with two separate commands:

$ golist --imported --skip-self --package-path %{goipath} 
$ golist --imported --skip-self --tests --package-path %{goipath}

https://pagure.io/go-rpm-macros/blob/master/f/rpm/macros.d/macros.go-rpm#_216

However the second line can request things the first line decided to filter out, because they are provided by the project itself. And that will probably break some builds once
https://github.com/rpm-software-management/rpm/pull/593 or
https://pagure.io/fesco/issue/2004 are done.

For dynamic BuildRequires to work reliably, we really need a single codebase+tests call (we can still use the codebase-only line when a packager disables tests in its specs).

$ golist --imported --skip-self --with-tests --package-path %{goipath}

Metadata Update from @nim:
- Issue tagged with: RFE

3 years ago

Metadata Update from @nim:
- Issue tagged with: core

3 years ago

Metadata Update from @qulogic:
- Issue set to the milestone: 1.0.0

3 years ago

Metadata Update from @qulogic:
- Issue assigned to qulogic

3 years ago

Metadata Update from @qulogic:
- Issue set to the milestone: 0.5.0 (was: 1.0.0)

3 years ago

Metadata Update from @qulogic:
- Issue set to the milestone: 0.10.0 (was: 0.5.0)

3 years ago

Do you have any example packages that trigger this problem?

It is not too difficult to implement, but so far, I haven't been able to find a package that outputs itself in the --tests --skip-self results

Metadata Update from @qulogic:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #24 Merged 3 years ago