golist relies on an obsolete release of gopkg.in/urfave/cli.v1 (1.18.1) and does not work with current releases
+ go build -buildmode pie -compiler gc '-tags=rpm_crashtraceback ' -ldflags ' -X github.com/gofed/symbols-extractor/version.commit=aecba475bf76f5269c11367da0a190419cd9a133 -X github.com/gofed/symbols-extractor/version=0 -B 0x53a515e8225a08687fb15659311c31138f10deef -extldflags '\''-Wl,-z,relro '\''' -a -v -x -o _bin/golist github.com/gofed/symbols-extractor/cmd/golist … cd /builddir/build/BUILD/symbols-extractor-aecba475bf76f5269c11367da0a190419cd9a133/_build/src/github.com/gofed/symbols-extractor/cmd/golist /usr/lib/golang/pkg/tool/linux_amd64/compile -o $WORK/b001/_pkg_.a -trimpath $WORK/b001 -shared -p main -complete -installsuffix shared -buildid W7hFQx2bLlwdklLGWaGL/W7hFQx2bLlwdklLGWaGL -goversion go1.10 -D "" -importcfg $WORK/b001/importcfg -pack ./golist.go # github.com/gofed/symbols-extractor/cmd/golist cmd/golist/golist.go:25:40: cannot use nil as type string in field value cmd/golist/golist.go:25:68: cannot use "" (type string) as type bool in field value cmd/golist/golist.go:25:72: cannot use false (type bool) as type *cli.StringSlice in field value cmd/golist/golist.go:26:41: cannot use nil as type string in field value cmd/golist/golist.go:26:74: cannot use "" (type string) as type bool in field value cmd/golist/golist.go:26:78: cannot use false (type bool) as type *cli.StringSlice in field value cmd/golist/golist.go:27:42: cannot use nil as type string in field value cmd/golist/golist.go:27:87: cannot use "" (type string) as type bool in field value cmd/golist/golist.go:27:91: cannot use false (type bool) as type *cli.StringSlice in field value cmd/golist/golist.go:28:61: cannot use "" (type string) as type bool in field value cmd/golist/golist.go:28:61: too many errors
Therefore, building golist as it is coded today requires the creation of a compat package, for a gopkg.in/urfave/cli.v1 version released in 29 Aug 2016, and not longer supported upstream
Metadata Update from @nim: - Assignee reset
Metadata Update from @nim: - Issue tagged with: BUG
Should we fix golist instead of requiring a compat package?
Yes that's what this issue is about: fixing golist so we can kill the compat package (or better not have to create it at all).
It is hidden in the golist binary we currently use because it vendors its deps (among other bad bad things).
Metadata Update from @qulogic: - Issue assigned to qulogic
Should I push a fix directly (I think I can at least) or open a PR?
@qulogic this is all originally @jchaloup 's code. He asked to split it in a separate repository, but I don't know what's the level of involvement he wants (and can) provide here. Ask him politely how he wants to do things (of course if he can not or does not want to answer over a reasonable time that would be an answer in itself)
(and then this is free software, and you have commit accesses, but asking before is better)
Fixed by #16.
Metadata Update from @qulogic: - Issue status updated to: Closed (was: Open)
Metadata Update from @qulogic: - Issue set to the milestone: 1.0.0
Metadata Update from @qulogic: - Issue set to the milestone: 0.5.0 (was: 1.0.0)
Metadata Update from @qulogic: - Issue set to the milestone: 0.10.0 (was: 0.5.0)
Log in to comment on this ticket.