#17 Go does not install SFiles not required by the arch
Closed 4 years ago by qulogic. Opened 4 years ago by eclipseo.

Remember we said we want noarch packages? So we include all files whatever the arch with IgnoredGoFiles.
SFiles are similar as they can be specific to an arch, but we don't have a "IgnoredSFiles" option to include them in all builds, so we end up with packages which are not exactly the same on every arch:

The immediate solution would be to include all files with the .s extension:

golist --include-extension .s --to-install --package-path ${goipath} $(expandflags)


That’s not hard to do (just add the flag to %goinstallflags ) but this variable is almost empty now, because all past file selection mistakes where fixed in golist

@qulogic do you need the workaround added to go-rpm-macros or can you fix it golist-side in time for @eclipseo ?

@qulogic reading golist code, it should just need the same kind of processing as for protobuf files
https://pagure.io/golist/blob/master/f/pkg/util/util.go#_77

(assuming we want all .s files added inconditionally)

I've pushed a new golist and rebuilt all of the packages here except golang-github-klauspost-crc32, because that one doesn't seem to parse properly.

Metadata Update from @qulogic:
- Issue status updated to: Closed (was: Open)

4 years ago

Login to comment on this ticket.

Metadata