freshmaker

Clone

#345 Handle on 'docker' advisories in RebuildImagesOnImageAdvisoryChange.
Merged 5 years ago by jkaluza. Opened 5 years ago by jkaluza.
jkaluza/freshmaker spec-fix  into  master

file modified
+8 -1 
@@ -36,7 +36,14 @@ 
 

      name = 'RebuildImagesOnImageAdvisoryChange'
 

  

      def can_handle(self, event):
 

-         return isinstance(event, ErrataAdvisoryStateChangedEvent)
 

+         if not isinstance(event, ErrataAdvisoryStateChangedEvent):
 

+             return False
 

+ 

+         if 'docker' not in event.advisory.content_types:
 

+             self.log_info('Skip non-Docker advisory %s.', event.advisory.errata_id)
 

+             return False
 

+ 

+         return True
 

  

      @fail_event_on_handler_exception
 

      def handle(self, event):

file modified
+10 
@@ -42,6 +42,16 @@ 
 

          self.handler = RebuildImagesOnImageAdvisoryChange()
 

          self.db_event = MagicMock()
 

  

+     def test_can_handle(self):
 

+         self.event.advisory.content_types = ["docker"]
 

+         ret = self.handler.can_handle(self.event)
 

+         self.assertTrue(ret)
 

+ 

+     def test_can_handle_non_docker_advisory(self):
 

+         self.event.advisory.content_types = ["rpm"]
 

+         ret = self.handler.can_handle(self.event)
 

+         self.assertFalse(ret)
 

+ 

      @patch.object(freshmaker.conf, 'handler_build_whitelist', new={
 

          'RebuildImagesOnImageAdvisoryChange': {
 

              "image": {"advisory_state": "SHIPPED_LIVE"}

Other content_types don't make sense for this handler.

:thumbsup:

Pull-Request has been merged by jkaluza
5 years ago
Metadata
None
No Tags
Changes Summary 2
+8 -1
file changed
freshmaker/handlers/bob/rebuild_images_on_image_advisory_change.py
+10 -0
file changed
tests/handlers/bob/test_rebuild_images_on_image_advisory_change.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.