#325 Pass lists to ODCS in prepare_odcs_compose_with_image_rpms.
Merged 5 months ago by jkaluza. Opened 5 months ago by jkaluza.
jkaluza/freshmaker odcs-builds-kwarg  into  master

@@ -362,6 +362,11 @@ 

              parsed_nvr = kobo.rpmlib.parse_nvra(rpm["nvra"])

              packages.add(parsed_nvr["name"])

  

+         # ODCS client expects list and not set for packages/builds, so convert

+         # them to lists.

+         builds = list(builds)

+         packages = list(packages)

+ 

          if not self.handler.dry_run:

              with krb_context():

                  new_compose = create_odcs_client().new_compose(

file modified
+2 -2

@@ -299,8 +299,8 @@ 

  

          # Ensure new_compose is called to request a new compose

          odcs.new_compose.assert_called_once_with(

-             '', 'build', builds=set(['avalon-logkit-2.1-14.el7', 'apache-commons-lang-2.6-15.el7']),

-             flags=['no_deps'], packages=set([u'avalon-logkit', u'apache-commons-lang']), sigkeys=[])

+             '', 'build', builds=['avalon-logkit-2.1-14.el7', 'apache-commons-lang-2.6-15.el7'],

+             flags=['no_deps'], packages=[u'avalon-logkit', u'apache-commons-lang'], sigkeys=[])

  

      def _create_consumer(self):

          hub = MagicMock()

no initial comment

Pull-Request has been merged by jkaluza

5 months ago