PR#14: Remove tailing dot from topic - freshmaker

freshmaker

#14 Remove tailing dot from topic

Merged 8 years ago by qwan. Opened 8 years ago by qwan.

qwan/freshmaker remove-tailing-dot-in-topic into master

Remove tailing dot from topic

Qixiang Wan • 8 years ago

f06fb6d

freshmaker/events.py

file modified

+1 -1

		`@@ -71,7 +71,7 @@`
		`topic_suffixes = []`
		`for parser in BaseEvent._parsers.values():`
		`topic_suffixes.extend(parser.topic_suffixes)`
		`- return ['{}.{}.'.format(pref.rstrip('.'), cat)`
		`+ return ['{}.{}'.format(pref.rstrip('.'), cat)`
		`for pref, cat`
		`in itertools.product(`
		`conf.messaging_topic_prefix,`

qwan commented 8 years ago

When topic is whole name already, adding a tailing dot will cause
freshmaker not be able to receive messages from expected topic.

fivaldi commented 8 years ago

LGTM :thumbsup:

cqi commented 8 years ago

LGTM

dcallagh commented 8 years ago

:+1:

In fedmsg (really zeromq) the topics are always prefix matched... so we just hope that everyone is always careful to give their topics non-overlapping names :-)

Pull-Request has been merged by qwan

8 years ago