Issue #9643: freeipa fails to build with nodejs22 on f39 and f40 - freeipa

freeipa

#9643 freeipa fails to build with nodejs22 on f39 and f40

Closed: fixed 6 months ago by frenaud. Opened 6 months ago by frenaud.

Issue

nodejs22 has been released on f39 and f40 and freeipa fails to build with this version.

Steps to Reproduce

git clone https://pagure.io/freeipa.git
cd freeipa
dnf install rpm-build
dnf builddep -b -D "with_wheels 1" -D "with_lint 1" --spec freeipa.spec.in --best --allowerasing --setopt=install_weak_deps=False
./makerpms.sh

The build is calling the command "node" but nodejs22 ships "node-22" instead

Actual behavior

./makerpm.sh
[...]
PYTHON=/usr/bin/python3 ./../../util/make-ui.sh
/root/freeipa/rpmbuild/BUILD/freeipa-4.13.0.dev202407300849+git708ef88a9/install/ui/util/build.sh: line 35: node: command not found
make[7]: *** [Makefile:638: app.js] Error 127
make[7]: Leaving directory '/root/freeipa/rpmbuild/BUILD/freeipa-4.13.0.dev202407300849+git708ef88a9/install/ui/build/freeipa'
make[6]: *** [Makefile:485: all-recursive] Error 1
make[6]: Leaving directory '/root/freeipa/rpmbuild/BUILD/freeipa-4.13.0.dev202407300849+git708ef88a9/install/ui/build'
make[5]: *** [Makefile:555: all-recursive] Error 1
make[5]: Leaving directory '/root/freeipa/rpmbuild/BUILD/freeipa-4.13.0.dev202407300849+git708ef88a9/install/ui'
make[4]: *** [Makefile:495: all-recursive] Error 1
make[4]: Leaving directory '/root/freeipa/rpmbuild/BUILD/freeipa-4.13.0.dev202407300849+git708ef88a9/install'
make[3]: *** [Makefile:698: all-recursive] Error 1
make[3]: Leaving directory '/root/freeipa/rpmbuild/BUILD/freeipa-4.13.0.dev202407300849+git708ef88a9'
make[2]: *** [Makefile:594: all] Error 2
make[2]: Leaving directory '/root/freeipa/rpmbuild/BUILD/freeipa-4.13.0.dev202407300849+git708ef88a9'
error: Bad exit status from /var/tmp/rpm-tmp.gi4LD5 (%build)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.gi4LD5 (%build)
make[1]: *** [Makefile:1201: _rpms-body] Error 1
make[1]: Leaving directory '/root/freeipa'
make: *** [Makefile:1198: rpms] Error 2

Expected behavior

Should build successfully

Additional info:

The spec file requires nodejs(abi) for building. On fedora 39 and fedora 40, the latest package is nodejs22, which provides /usr/bin/node-22. On fedora 41+, nodejs22 provides /usr/bin/node (as it will be the default version, there is a symlink from /usr/bin/node to /usr/bin/node-22).

Metadata Update from @frenaud:
- Issue assigned to frenaud

6 months ago

Metadata Update from @frenaud:
- Custom field on_review adjusted to https://github.com/freeipa/freeipa/pull/7466

6 months ago

frenaud commented 6 months ago

master:

acb87a8 spec file: do not use nodejs-22 on f39 and f40

frenaud commented 6 months ago

ipa-4-11:

99dcb96 spec file: do not use nodejs-22 on f39 and f40

frenaud commented 6 months ago

ipa-4-12:

2ddca5d spec file: do not use nodejs-22 on f39 and f40

Metadata Update from @frenaud:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

6 months ago

Metadata

Assignee

frenaud

Tags

None

Blocking

None

Depending on

None

Priority

None

Milestone

None

affects_doc

None

source

None

knownissue

None

type

None

blockedby

None

test_case

None

component

None

blocking

None

on_review

https://github.com/freeipa/freeipa/pull/7466

keywords

None

test_coverage

None

reviewer

None

external_tracker

None

tester

None

changelog

None

design

None

rhbz

None

freeipa

Source Code

#9643 freeipa fails to build with nodejs22 on f39 and f40 Closed: fixed 6 months ago by frenaud. Opened 6 months ago by frenaud.

Issue

Steps to Reproduce

Actual behavior

Expected behavior

Additional info:

Metadata

#9643 freeipa fails to build with nodejs22 on f39 and f40

Closed: fixed 6 months ago by frenaud. Opened 6 months ago by frenaud.