#9554 Nightly tests: fail to build if @389ds/389-ds-base-nightly copr repo is enabled
Closed: fixed 10 months ago by frenaud. Opened 10 months ago by frenaud.

The master branch of freeipa fails to build if the copr repo @389ds/389-ds-base-nightly is enabled.
Detected in our nightly tests in PR #3486, and the file build.log contains the following error:

prepost.c: In function 'ipapwd_pre_bind':
prepost.c:1560:9: error: implicit declaration of function 'slapi_pblock_set_flag_operation_notes' [-Werror=implicit-function-declaration]
 1560 |         slapi_pblock_set_flag_operation_notes(pb, SLAPI_OP_NOTE_MFA_AUTH);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The problem is related to this commit:
23b224d ipa-pwd-extop: add MFA note in case of a successful LDAP bind with OTP

The function is provided by 389-ds and declared in slapi-private.h:

uint32_t slapi_pblock_get_operation_notes(Slapi_PBlock *pb);

Sure, looking into this. I think we'll just do a local definition of that since the note got detected properly (hence we are in this branch).

Metadata Update from @abbra:
- Issue assigned to abbra

10 months ago

master:

  • e431ce0 ipa-pwd-extop: declare operation notes support from 389-ds locally

ipa-4-11:

  • db80428 ipa-pwd-extop: declare operation notes support from 389-ds locally

ipa-4-10:

  • b1a0423 ipa-pwd-extop: declare operation notes support from 389-ds locally

Metadata Update from @frenaud:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

10 months ago

Log in to comment on this ticket.

Metadata