Issue #9514: Make sure a default NetBIOS name is set if not passed in by ADTrust instance constructor - freeipa

freeipa

#9514 Make sure a default NetBIOS name is set if not passed in by ADTrust instance constructor

Closed: fixed a year ago by frenaud. Opened a year ago by abbra.

we default the option netbios_name to None in /usr/libexec/ipa/oddjob/org.freeipa.server.config-enable-sid and do not get it defaulted to a value we generate if it is None. A workaround would be to pass the netbios name explicitly to the tool and a fix is to use make_netbios_name out of the realm if not passed:

# ipa -e in_server=True console
(Custom IPA interactive Python console)
    api: IPA API object
    pp: pretty printer
>>> from ipaserver.install.adtrustinstance import make_netbios_name
>>> make_netbios_name(api.env.realm)
'EXAMPLE'

abbra commented a year ago

This affects /usr/libexec/ipa/oddjob/org.freeipa.server.config-enable-sid specifically because it passes None as netbios_name to ADTrustInstance if not overidden.

abbra commented a year ago

PR: https://github.com/freeipa/freeipa/pull/7161

frenaud commented a year ago

master:

9b45610 adtrustinstance: make sure NetBIOS name defaults are set properly

Metadata Update from @frenaud:
- Custom field on_review adjusted to https://github.com/freeipa/freeipa/pull/7161
- Custom field rhbz adjusted to https://issues.redhat.com/browse/RHEL-21938, https://issues.redhat.com/browse/RHEL-21937

a year ago

frenaud commented a year ago

ipa-4-11:

eab52d3 adtrustinstance: make sure NetBIOS name defaults are set properly

frenaud commented a year ago

ipa-4-10:

3baa30a adtrustinstance: make sure NetBIOS name defaults are set properly

frenaud commented a year ago

ipa-4-9:

2f17319 adtrustinstance: make sure NetBIOS name defaults are set properly

Metadata Update from @frenaud:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

a year ago

Metadata

Assignee

abbra

Tags

Blocking

None

Depending on

None

Priority

None

Milestone

FreeIPA 4.9

None

affects_doc

None

source

None

knownissue

None

type

None

blockedby

None

test_case

None

component

None

blocking

None

on_review

https://github.com/freeipa/freeipa/pull/7161

keywords

None

test_coverage

None

reviewer

None

external_tracker

None

tester

None

changelog

None

design

None

rhbz

https://issues.redhat.com/browse/RHEL-21938
https://issues.redhat.com/browse/RHEL-21937

freeipa

Source Code

#9514 Make sure a default NetBIOS name is set if not passed in by ADTrust instance constructor Closed: fixed a year ago by frenaud. Opened a year ago by abbra.

Metadata

trust

#9514 Make sure a default NetBIOS name is set if not passed in by ADTrust instance constructor

Closed: fixed a year ago by frenaud. Opened a year ago by abbra.