After running Covscan the following issue was raised:
1. freeipa-4.9.11/daemons/ipa-kdb/ipa_kdb_mspac.c:1062: cond_notnull: Condition "lentry", taking true branch. Now the value of "lentry" is not "NULL". 2. freeipa-4.9.11/daemons/ipa-kdb/ipa_kdb_mspac.c:1089: notnull: At condition "lentry", the value of "lentry" cannot be "NULL". 3. freeipa-4.9.11/daemons/ipa-kdb/ipa_kdb_mspac.c:1089: dead_error_condition: The condition "!lentry" cannot be true. 4. freeipa-4.9.11/daemons/ipa-kdb/ipa_kdb_mspac.c:1090: dead_error_begin: Execution cannot reach this statement: "kerr = 2;". # 1088| sentry = ldap_first_entry(ipactx->lcontext, sresults); # 1089| if (!lentry) { # 1090|-> kerr = ENOENT; # 1091| goto done; # 1092| }
At this point, lentry cannot be NULL, but it seems that the variable that should be tested is sentry.
lentry
sentry
Metadata Update from @rjeffman: - Issue assigned to rjeffman
PR: https://github.com/freeipa/freeipa/pull/6799
master:
ipa-4-10:
ipa-4-9:
Metadata Update from @frenaud: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
Log in to comment on this ticket.