#9339 Broken support for dnspython < 2
Closed: fixed 2 years ago by frenaud. Opened 2 years ago by slev.

The fix for https://pagure.io/freeipa/issue/9158 only supports dnspython >= 2.

For example, fasttest fail:

[builder@localhost .in]$ python3 -c 'from importlib.metadata import version; print(version("dnspython"))'
1.16.0
+ make fasttest                                                                  
make: Entering directory '/usr/src/RPM/BUILD/freeipa-4.9.11'                     
(cd ./ipaplatform && make override.py)                                           
make[1]: Entering directory '/usr/src/RPM/BUILD/freeipa-4.9.11/ipaplatform'      
make[1]: 'override.py' is up to date.                                            
make[1]: Leaving directory '/usr/src/RPM/BUILD/freeipa-4.9.11/ipaplatform'       
(cd ./ipapython && make version.py)                                              
make[1]: Entering directory '/usr/src/RPM/BUILD/freeipa-4.9.11/ipapython'        
make[1]: 'version.py' is up to date.                                             
make[1]: Leaving directory '/usr/src/RPM/BUILD/freeipa-4.9.11/ipapython'         
PATH=/usr/src/RPM/BUILD/freeipa-4.9.11/ipatests:$PATH PYTHONPATH=/usr/src/RPM/BUILD/freeipa-4.9.11 \
    /usr/bin/python3 ipatests/ipa-run-tests \                                    
    --skip-ipaapi \                                                              
    --ignore /usr/src/RPM/BUILD/freeipa-4.9.11/ipatests/test_integration \       
    --ignore /usr/src/RPM/BUILD/freeipa-4.9.11/ipatests/test_xmlrpc              
ImportError while loading conftest '/usr/src/RPM/BUILD/freeipa-4.9.11/ipatests/conftest.py'.
conftest.py:14: in <module>                                                      
    from ipalib import api                                                       
../ipalib/__init__.py:919: in <module>                                           
    from ipalib import plugable                                                  
../ipalib/plugable.py:44: in <module>                                            
    from ipalib.config import Env                                                
../ipalib/config.py:41: in <module>                                              
    from ipaplatform.tasks import tasks                                          
../ipaplatform/_importhook.py:34: in load_module                                 
    platform_mod = importlib.import_module(alias)                                
../ipaplatform/altlinux/tasks.py:10: in <module>                                 
    from ipaplatform.redhat.tasks import RedHatTaskNamespace                     
../ipaplatform/redhat/tasks.py:52: in <module>                                   
    from ipaplatform.redhat.authconfig import get_auth_tool                      
../ipaplatform/redhat/authconfig.py:28: in <module>                              
    from ipapython.admintool import ScriptError                                  
../ipapython/admintool.py:33: in <module>                                        
    from ipapython import config                                                 
../ipapython/config.py:35: in <module>                                           
    from ipapython.dnsutil import query_srv                                      
../ipapython/dnsutil.py:75: in <module>                                          
    class DNSResolver(dns.resolver.Resolver):                                    
../ipapython/dnsutil.py:147: in DNSResolver                                      
    ???                                                                          
E   AttributeError: type object 'Resolver' has no attribute 'nameservers'        
make: *** [Makefile:1236: fasttest] Error 4                                      
make: Leaving directory '/usr/src/RPM/BUILD/freeipa-4.9.11'

nameservers was transformed into the property in dnspython 2:
https://github.com/rthalley/dnspython/commit/bbf0cfd239ffa6deeb67a4787bd292e9a972af74


Metadata Update from @slev:
- Issue assigned to slev

2 years ago

Metadata Update from @slev:
- Assignee reset

2 years ago

master:

  • 1420599 dns: Fix support for dnspython 1.1x

ipa-4-9:

  • c57507f dns: Fix support for dnspython 1.1x

ipa-4-10:

  • b152e8c dns: Fix support for dnspython 1.1x

Metadata Update from @frenaud:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

2 years ago

Log in to comment on this ticket.

Metadata