#9318 Incomplete fast lint/codestyle check if both Python template files and Python modules were changed
Closed: fixed a year ago by frenaud. Opened a year ago by slev.

Make some changes to reproduce this issue:

[user@host freeipa]$ for f in test.py test1.py test.py.in test1.py.in; do cat <<< '#!/usr/bin/python3' > "$f" ; git add "$f" ; done

Either fastlint or fastcodestyle target checks only 1st found file from list if both Python template files and Python modules were changed.

Actual result:

[user@host freeipa]$ make "GIT_BRANCH=master" fastcodestyle
...
Fast code style checking with /usr/bin/python3 from branch 'master'
Fast code style checking for files:
test.py

pycodestyle
-----------
local configuration: in /test/freeipa
checking ./test.py
[user@host freeipa]$ make "GIT_BRANCH=master" fastlint
...
Fast linting with /usr/bin/python3 from branch 'master'
Fast linting files:
test.py


pylint
...

Expected result:
fast lint/codestyle should check all changed Python files.


Metadata Update from @slev:
- Issue assigned to slev

a year ago

master:

  • d32c640 fastlint: Correct concatenation of file lists

ipa-4-9:

  • d8418ce fastlint: Correct concatenation of file lists

ipa-4-10:

  • 5402627 fastlint: Correct concatenation of file lists

Metadata Update from @frenaud:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

a year ago

Login to comment on this ticket.

Metadata