#8772 pylint 2.7.0-2.7.2 introduces new warnings
Closed: fixed 2 years ago by frenaud. Opened 2 years ago by slev.

With Pylint 2.7.0-2.7.2 there are new warnings:

************* Module ipatests.test_integration.test_dns_locations
ipatests/test_integration/test_dns_locations.py:46: [R1710(inconsistent-return-statements), resolve_records_from_server] Either all return statements in a function should return an expression, or none of them should.)
************* Module ipaserver.plugins.server
ipaserver/plugins/server.py:274: [R1727(condition-evals-to-constant), server_mod.post_callback] Boolean condition ''ipalocation_location' or 'ipaserviceweight' in options' will always evaluate to ''ipalocation_location'')
************* Module ipapython.install.cli
ipapython/install/cli.py:299: [R1710(inconsistent-return-statements), ConfigureTool.init_configurator] Either all return statements in a function should return an expression, or none of them should.)
************* Module ipalib.install.kinit
ipalib/install/kinit.py:25: [R1710(inconsistent-return-statements), kinit_keytab] Either all return statements in a function should return an expression, or none of them should.)
************* Module ipa-replica-manage
install/tools/ipa-replica-manage:879: [R1729(use-a-generator), ensure_last_services] Use a generator instead 'any('CA' in o for o in other_services)')
install/tools/ipa-replica-manage:884: [R1729(use-a-generator), ensure_last_services] Use a generator instead 'any('DNS' in o for o in other_services)')

Actual logical error:

ipaserver/plugins/server.py:274: [R1727(condition-evals-to-constant), server_mod.post_callback] Boolean condition ''ipalocation_location' or 'ipaserviceweight' in options' will always evaluate to ''ipalocation_location'')

This wasn't catched before in Tox task fixing for Pylint 2.7.0 because Tox environment run Pylint only over ipaclient, ipalib and ipapython. It will be addressed in PR.


Metadata Update from @slev:
- Issue assigned to slev

2 years ago

master:

  • 3ac2cdf Azure: Make it possible to pass additional Pytest args
  • 85c63fb Azure: Show disk usage
  • 908e8cf Azure: Template docs build
  • 5afe137 Azure: Run chronyd in Docker
  • 45d2381 Azure: Collect Host's systemd journal
  • 5daa41f Azure: Warn about Host's AVC and SECCOMP
  • 72adb32 Azure: Disable AppArmor profile for chrony
  • 056c511 Azure: Don't install pypi's docker
  • 91e7452 pylint: Fix several warnings
  • 7855c77 Azure: Run Lint task as separate job

ipa-4-9:

  • 380336d Azure: Make it possible to pass additional Pytest args
  • adc4d8d Azure: Show disk usage
  • e80ff6f Azure: Template docs build
  • 255be04 Azure: Run chronyd in Docker
  • 8cdc7bf Azure: Collect Host's systemd journal
  • d47847b Azure: Warn about Host's AVC and SECCOMP
  • 572f203 Azure: Disable AppArmor profile for chrony
  • 6c1dc1b Azure: Don't install pypi's docker
  • 2bec09a pylint: Fix several warnings
  • 188a279 Azure: Run Lint task as separate job

ipa-4-8:

  • 695a42d Azure: Make it possible to pass additional Pytest args
  • ea5e38c Azure: Show disk usage
  • 9374e99 Azure: Make unique built artifacts names
  • 7f35e8e Azure: Collect Host's systemd journal
  • b2e6bbf Azure: Warn about Host's AVC and SECCOMP
  • e3ab472 Azure: Disable AppArmor profile for chrony
  • 781ca84 Azure CI: use Ubuntu-20.04 image by default
  • 9dd4983 Azure CI: use PPA to provide newer libseccomp version
  • 902146d Azure: Don't install pypi's docker
  • 030d8b3 pylint: Fix several warnings
  • 8e97deb Azure: Run Lint task as separate job

Metadata Update from @frenaud:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata