With Pylint 2.7.0-2.7.2 there are new warnings:
************* Module ipatests.test_integration.test_dns_locations ipatests/test_integration/test_dns_locations.py:46: [R1710(inconsistent-return-statements), resolve_records_from_server] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipaserver.plugins.server ipaserver/plugins/server.py:274: [R1727(condition-evals-to-constant), server_mod.post_callback] Boolean condition ''ipalocation_location' or 'ipaserviceweight' in options' will always evaluate to ''ipalocation_location'') ************* Module ipapython.install.cli ipapython/install/cli.py:299: [R1710(inconsistent-return-statements), ConfigureTool.init_configurator] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipalib.install.kinit ipalib/install/kinit.py:25: [R1710(inconsistent-return-statements), kinit_keytab] Either all return statements in a function should return an expression, or none of them should.) ************* Module ipa-replica-manage install/tools/ipa-replica-manage:879: [R1729(use-a-generator), ensure_last_services] Use a generator instead 'any('CA' in o for o in other_services)') install/tools/ipa-replica-manage:884: [R1729(use-a-generator), ensure_last_services] Use a generator instead 'any('DNS' in o for o in other_services)')
Actual logical error:
ipaserver/plugins/server.py:274: [R1727(condition-evals-to-constant), server_mod.post_callback] Boolean condition ''ipalocation_location' or 'ipaserviceweight' in options' will always evaluate to ''ipalocation_location'')
This wasn't catched before in Tox task fixing for Pylint 2.7.0 because Tox environment run Pylint only over ipaclient, ipalib and ipapython. It will be addressed in PR.
Metadata Update from @slev: - Issue assigned to slev
Fixed in https://github.com/freeipa/freeipa/pull/5660
master:
ipa-4-9:
ipa-4-8:
Metadata Update from @frenaud: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.