testing_master_previous Nightly PR 254 logs
self = <ipatests.test_webui.test_loginscreen.TestLoginScreen object at 0x7efd724b1750> actual_form = [<selenium.webdriver.firefox.webelement.FirefoxWebElement (session="d4092322-8008-444a-90b4-bb3f533d672d", element="8f...nt.FirefoxWebElement (session="d4092322-8008-444a-90b4-bb3f533d672d", element="a01b4b7e-c17c-4bb9-8162-43d67370de80")>] expected_form = [('username', 'Username', False, True, 'text', 'username', ...), ('password', 'Password', False, True, 'password', 'password', ...)] def assert_form_equals(self, actual_form, expected_form): """ Compare two forms """ assert len(actual_form) == len(expected_form) for act_row, exp_row in zip(actual_form, expected_form): # structure of rows # label_name, label_text, # required, editable, # input_type, input_name, # input_text, placeholder > assert self.get_data_from_form_row(act_row) == exp_row E AssertionError: assert ('password', ...assword', ...) == ('password', ...assword', ...) E At index 7 diff: 'Password or Password+One Time-Password' != 'Password or Password+One-Time Password' E Full diff: E ( E 'password', E 'Password', E False, E True,... E E ...Full output truncated (9 lines hidden), use '-vv' to show test_webui/test_loginscreen.py:216: AssertionError
There is a discrepancy in strings used for this purpose:
$ grep -nr 'Password or Password+One Time-Password' . ./ipaserver/plugins/internal.py:409: "password_and_otp": _("Password or Password+One Time-Password"), ./ipaserver/plugins/internal.py:1695: "password_and_otp": _("Password or Password+One Time-Password"), ./ipatests/test_webui/data_loginscreen.py:34: PASSWD_ITEST_USER, 'Password or Password+One Time-Password'), $ grep -nr 'Password or Password+One-Time Password' . ./install/ui/src/freeipa/widgets/LoginScreen.js:650: 'Password or Password+One-Time Password' ./install/ui/test/data/i18n_messages.json:209: "password_and_otp": "Password or Password+One-Time Password", ./install/ui/test/data/i18n_messages.json:757: "password_and_otp": "Password or Password+One-Time Password", ./ipatests/test_webui/data_loginscreen.py:124: 'Password or Password+One-Time Password'), ./ipatests/test_webui/data_loginscreen.py:149: 'Password or Password+One-Time Password'),
The issue is linked to the recent commits fixing issue #5628 and should be fixed in ipa-4-8 and master branches: master:
13b1778 WebUI: move OTP to be the last field in the PW reset form d63a91d WebUI: reword OTP info message displayed during PW reset ea5c0a1 Unify spelling of "One-Time Password"
Metadata Update from @frenaud: - Issue assigned to frenaud
Metadata Update from @frenaud: - Custom field on_review adjusted to https://github.com/freeipa/freeipa/pull/4849
master:
ipa-4-8:
Metadata Update from @frenaud: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.