clang has a fairly good static code analyyer that is easy to use, https://clang-analyzer.llvm.org/scan-build.html . We should scan our code and fix issues. Master h
$ sudo dnf install -y clang-analyzer $ ./autogen.sh $ make clean $ scan-build -o report make -j4 -s
scan-build finds 50 issues in master. <img alt="index.html" src="/freeipa/issue/raw/files/1f738223a00cb618c98f5a36a9740e12897812b83f62ac3423dec0ba12a3af9f-index.html" />
<img alt="scanresult.tar.gz" src="/freeipa/issue/raw/files/dad27db2b62453ac11165fb0b07e9b2396b7ed10b71ef568faba8a8fb8f304e8-scanresult.tar.gz" />
In addition to that I would suggest to enable at least -Wall maybe even -Wextra globally. Currently -Wall is enabled for daemons and client.
-Wall
-Wextra
daemons
client
master:
@frenaud is this issue fixed, please?
@pcech this is not an "issue" but rather a suggestion to scan our C code. This means executing scan-build when we build + fixing all the issues potentially uncovered by the tool. Note that we already scan downstream using covscan.
And to answer your question, no, it's not done yet. The referenced commits are related to this issue but don't fix it.
Login to comment on this ticket.