#8307 make devcheck fails for test_ipatests_plugins/test_ipa_run_tests.py
Closed: fixed 4 years ago by cheimes. Opened 4 years ago by carbenium.

Issue

The test_ipatests_plugins/test_ipa_run_tests.py unit tests executed through the make devcheck target fail.

Steps to Reproduce

  1. make devcheck

Actual behavior

All of the tests fail with

E               FileNotFoundError: [Errno 2] No such file or directory: 'ipa-run-tests'

Expected behavior

They should pass.

Version/Release/Distribution

git master; 35e1ebb2f3eb2d46f4080860ebe4e71421f80b54


The test case falsely assumes that ipa-run-tests is installed with python3-ipatests package.

Please try

diff --git a/Makefile.am b/Makefile.am
index e2516351e..980440c82 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -208,7 +208,8 @@ if ! WITH_JSLINT
        @echo "ERROR: jslint not available"; exit 1
 endif
        @ # just tests, aci, api and pylint on Python 3
-       PYTHONPATH=$(abspath $(top_srcdir)) $(PYTHON) ipatests/ipa-run-tests \
+       PATH=$(abspath ipatests):$$PATH PYTHONPATH=$(abspath $(top_srcdir)) \
+           $(PYTHON) ipatests/ipa-run-tests \
            --ipaclient-unittests
        $(MAKE) $(AM_MAKEFLAGS) acilint apilint polint pylint jslint rpmlint yamllint check
        @echo "All tests passed."

Patch works nicely. Thanks!

Metadata Update from @cheimes:
- Custom field on_review adjusted to https://github.com/freeipa/freeipa/pull/4659
- Issue assigned to cheimes
- Issue priority set to: minor
- Issue set to the milestone: FreeIPA 4.8.7
- Issue tagged with: test-failure

4 years ago

master:

ipa-4-8:

Metadata Update from @cheimes:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

4 years ago

Log in to comment on this ticket.

Metadata