As a developer I want 'make fastlint' to process our .in files like ipa-client-automount.in so that errors are found earlier.
You can't check .in files, because they are not valid Python files. I see two options:
.in
1) Create the output files, then validate the output files (e.g. ipa-client-automount.in -> ipa-client-automount, then check ipa-client-automount) 2) Move all code out of the .in files into proper Python modules and convert the script files into two liners (import + main()).
ipa-client-automount.in
ipa-client-automount
main()
I would prefer approach (2). The .in files have several disadvantages. The code is not reusable. IDEs don't recognize the files as Python files.
Thanks for the input @cheimes - after some experimentation #2 sounds like the best option.
Files to change: ./client/ipa-client-automount.in ./daemons/dnssec/ipa-dnskeysync-replica.in ./daemons/dnssec/ipa-dnskeysyncd.in ./daemons/dnssec/ipa-ods-exporter.in ./install/certmonger/dogtag-ipa-ca-renew-agent-submit.in ./install/certmonger/ipa-server-guard.in ./install/oddjob/com.redhat.idm.trust-fetch-domains.in ./install/tools/ipa-adtrust-install.in ./install/tools/ipa-ca-install.in ./install/tools/ipa-compat-manage.in ./install/tools/ipa-custodia-check.in ./install/tools/ipa-dns-install.in ./install/tools/ipa-httpd-kdcproxy.in ./install/tools/ipa-managed-entries.in ./install/tools/ipa-nis-manage.in ./install/tools/ipa-pki-retrieve-key.in ./install/tools/ipa-pki-wait-running.in ./install/tools/ipa-replica-conncheck.in ./install/tools/ipa-replica-manage.in ./install/tools/ipactl.in and on a 2nd pass: ./install/restart_scripts/renew_ca_cert.in ./install/restart_scripts/renew_kdc_cert.in ./install/restart_scripts/renew_ra_cert.in ./install/restart_scripts/renew_ra_cert_pre.in ./install/restart_scripts/restart_dirsrv.in ./install/restart_scripts/restart_httpd.in ./install/restart_scripts/stop_pkicad.in Those three can stay as-is: ./ipasetup.py.in ./makeaci.in ./makeapi.in
master:
ipa-4-7:
For now I'll limit this to ipactl and ipa-client-automount. We can do the others as we modify them.
Metadata Update from @fcami: - Custom field on_review adjusted to https://github.com/freeipa/freeipa/pull/3296
Metadata Update from @fcami: - Issue set to the milestone: FreeIPA 4.8
Metadata Update from @fcami: - Custom field on_review adjusted to https://github.com/freeipa/freeipa/pull/3296 https://github.com/freeipa/freeipa/pull/3335 (was: https://github.com/freeipa/freeipa/pull/3296)
Metadata Update from @abbra: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.