The usual build flow is something like: 1. build (e.g. make) 2. check (e.g. make pylint)
So, following this way I got an error:
Pylint on /usr/bin/python3 is running, please wait ... ************* Module ipa-dnskeysync-replica daemons/dnssec/ipa-dnskeysync-replica:53: [R1710(inconsistent-return-statements), find_unwrapping_key] Either all return statements in a function should return an expression, or none of them should.)
PR tests run make lint without all the needed deps and thus, just skip some of Python stuff. This is the full list of skipped items:
make lint
diff -u pylint_clean_sorted pylint_all_sorted --- pylint_clean_sorted 2019-04-18 19:01:23.331588363 +0000 +++ pylint_all_sorted 2019-04-18 19:01:05.970692757 +0000 @@ -3,10 +3,23 @@ ./client/ipa-client-install ./contrib/copy-schema-to-ca-RHEL6.py ./contrib/lite-server.py +./daemons/dnssec/ipa-dnskeysync-replica +./daemons/dnssec/ipa-dnskeysyncd +./daemons/dnssec/ipa-ods-exporter ./daemons/ipa-otpd/test.py ./doc/examples/examples.py ./doc/examples/python-api.py +./install/certmonger/dogtag-ipa-ca-renew-agent-submit +./install/certmonger/ipa-server-guard ./install/migration/migration.py +./install/oddjob/com.redhat.idm.trust-fetch-domains +./install/restart_scripts/renew_ca_cert +./install/restart_scripts/renew_kdc_cert +./install/restart_scripts/renew_ra_cert +./install/restart_scripts/renew_ra_cert_pre +./install/restart_scripts/restart_dirsrv +./install/restart_scripts/restart_httpd +./install/restart_scripts/stop_pkicad ./install/share/wsgi.py ./install/tools/ipa-adtrust-install ./install/tools/ipa-advise @@ -36,6 +49,7 @@ ./install/tools/ipa-winsync-migrate ./install/tools/ipactl ./install/wsgi/plugins.py +./ipa ./ipaclient ./ipalib ./ipaplatform
master:
make pylint
inconsistent-return-statements
ipa-4-7:
Metadata Update from @cheimes: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
Thanks for the ticket and the PR!
Login to comment on this ticket.