#710 Unused value in initdefault_encoding_utf8
Closed: Fixed None Opened 13 years ago by jhrozek.

in ipapython/py_default_encoding/default_encoding_utf8.c:

  52PyMODINIT_FUNC
  53initdefault_encoding_utf8(void) 
  54{
  55    PyObject* m;
  56
  57    PyUnicode_SetDefaultEncoding("utf-8");
Pointer "m" returned by "Py_InitModule4_64("default_encoding_utf8", methods, "Forces the default encoding to utf-8", NULL, 1013)" is never used.
  58    m = Py_InitModule3("default_encoding_utf8", methods, "Forces the default encoding to utf-8");
  59}

You might want to check with John Dennis on this one (jdennis@redhat.com). He is the original author of this.

I checked the C source and available resources in the documentation - we don't need to store return value of Py_InitModule3. It would be needed for example we by PyModule_AddObject(m, ...), but this is not our case.

Metadata Update from @jhrozek:
- Issue assigned to mkosek
- Issue set to the milestone: FreeIPA 2.0 - 2011/01 (cleanup)

7 years ago

Login to comment on this ticket.

Metadata