#6604 Make pylint and jsl optional (and other issues)
Closed: fixed a year ago by cheimes. Opened 2 years ago by cheimes.

configure fails when either pylint or jsl are not available. Both components are only relevant for developers. Default settings for configure should be tailored towards ordinary users. A developer will

$ sudo dnf remove pylint jsl
$ autoreconf -ifv
$ ./configure
...
checking for Pylint... /usr/bin/python: No module named pylint
configure: error: cannot find pylint for /usr/bin/python
$ sudo dnf install -y pylint
$ ./configure
checking for Pylint... yes
checking for jsl... no
configure: error: cannot find JS lint

Also the options to disable linters are confusing:

$ ./configure --disable-pylint --without-jslint

One component uses --disable, the other --without. Also it's called jsl, not jslint.

Lastly --disable-pylint doesn't work fully. Despite --disable-pylint, configure still creates a pylint target when pylint is available.

$ ./configure --disable-pylint --without-jslint
$ make pylint
...
echo "Pylint is running, please wait ..."; \
PYTHONPATH=. /usr/bin/python -m pylint \
        --rcfile=./pylintrc ${FILES}
Pylint is running, please wait ...
/usr/bin/python: No module named pylint
Makefile:1126: recipe for target 'pylint' failed

What is the use case? I what situation would ordinary user run this?

I'm trying to make it easier and more pleasant to build FreeIPA from source. Both pylint and jsl are irrelevant for releases. My direct use case are Python packages from source distributions or git checkouts.

master:

  • 5c18fea CONFIGURE: Fix detection of pylint
  • 3f91469 CONFIGURE: Update help message for jslint
  • b82d285 SPEC: Fix build in mock

Metadata Update from @cheimes:
- Issue assigned to someone
- Issue set to the milestone: FreeIPA 4.5

2 years ago

TODO: update wiki before closing this ticket

Metadata Update from @cheimes:
- Issue close_status updated to: None

2 years ago

master:

  • f1f6350 Make pylint and jsl optional

Metadata Update from @mbasti:
- Issue set to the milestone: FreeIPA 4.5.1 (was: FreeIPA 4.5)

2 years ago

master:

  • e357133 Add make devcheck for developers
  • 6c092c2 Skip test_session_storage in ipaclient unittest mode

ipa-4-5:

  • 89ab24f Add make devcheck for developers
  • c80adf6 Skip test_session_storage in ipaclient unittest mode

Metadata Update from @pvoborni:
- Issue set to the milestone: FreeIPA 4.7 (was: FreeIPA 4.5.1)

2 years ago

FreeIPA's configure script does not require jsl and pylint. Tests are passing.

Metadata Update from @cheimes:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

a year ago

Login to comment on this ticket.

Metadata