#6479 ignore_import_errors breaks other meta importers
Closed: Invalid None Opened 7 years ago by cheimes.

$ ./makeaci 
./makeaci: ipaplatform/_importhook.py:18: ignoring ImportError: No module named ipaplatform.importlib
./makeaci: ipaplatform/_importhook.py:19: ignoring ImportError: No module named ipaplatform.sys
./makeaci: ipaplatform/_importhook.py:21: ignoring ImportError: No module named ipaplatform.ipaplatform
Traceback (most recent call last):
  File "./makeaci", line 35, in <module>
    from ipalib import api
  File "/home/heimes/redhat/freeipa/ipalib/__init__.py", line 885, in <module>
    from ipalib import plugable
  File "/home/heimes/redhat/freeipa/ipalib/plugable.py", line 41, in <module>
    from ipalib import errors
  File "/home/heimes/redhat/freeipa/ipalib/errors.py", line 109, in <module>
    from ipalib.text import ngettext as ungettext
  File "/home/heimes/redhat/freeipa/ipalib/text.py", line 119, in <module>
    from ipalib.request import context
  File "/home/heimes/redhat/freeipa/ipalib/request.py", line 28, in <module>
    from ipalib.base import ReadOnly, lock
  File "/home/heimes/redhat/freeipa/ipalib/base.py", line 28, in <module>
    from ipalib.constants import NAME_REGEX, NAME_ERROR
  File "/home/heimes/redhat/freeipa/ipalib/constants.py", line 25, in <module>
    from ipaplatform.paths import paths
  File "/home/heimes/redhat/freeipa/ipaplatform/paths.py", line 10, in <module>
    from . import _importhook
  File "/home/heimes/redhat/freeipa/ipaplatform/_importhook.py", line 92, in <module>
    metaimporter = IpaMetaImporter()
  File "/home/heimes/redhat/freeipa/ipaplatform/_importhook.py", line 40, in __init__
    self.platform = self._get_platform()
  File "/home/heimes/redhat/freeipa/ipaplatform/_importhook.py", line 63, in _get_platform
    importlib.import_module('ipaplatform.{}'.format(platform))
AttributeError: 'FailedImport' object has no attribute 'import_module'

When I disable the ignore_import_errors meta importer, ./makeaci and make lint pass just fine.


Mpf, I used MD instead of Trac markup.

$ ./makeaci 
./makeaci: ipaplatform/_importhook.py:18: ignoring ImportError: No module named ipaplatform.importlib
./makeaci: ipaplatform/_importhook.py:19: ignoring ImportError: No module named ipaplatform.sys
./makeaci: ipaplatform/_importhook.py:21: ignoring ImportError: No module named ipaplatform.ipaplatform
Traceback (most recent call last):
  File "./makeaci", line 35, in <module>
    from ipalib import api
  File "/home/heimes/redhat/freeipa/ipalib/__init__.py", line 885, in <module>
    from ipalib import plugable
  File "/home/heimes/redhat/freeipa/ipalib/plugable.py", line 41, in <module>
    from ipalib import errors
  File "/home/heimes/redhat/freeipa/ipalib/errors.py", line 109, in <module>
    from ipalib.text import ngettext as ungettext
  File "/home/heimes/redhat/freeipa/ipalib/text.py", line 119, in <module>
    from ipalib.request import context
  File "/home/heimes/redhat/freeipa/ipalib/request.py", line 28, in <module>
    from ipalib.base import ReadOnly, lock
  File "/home/heimes/redhat/freeipa/ipalib/base.py", line 28, in <module>
    from ipalib.constants import NAME_REGEX, NAME_ERROR
  File "/home/heimes/redhat/freeipa/ipalib/constants.py", line 25, in <module>
    from ipaplatform.paths import paths
  File "/home/heimes/redhat/freeipa/ipaplatform/paths.py", line 10, in <module>
    from . import _importhook
  File "/home/heimes/redhat/freeipa/ipaplatform/_importhook.py", line 92, in <module>
    metaimporter = IpaMetaImporter()
  File "/home/heimes/redhat/freeipa/ipaplatform/_importhook.py", line 40, in __init__
    self.platform = self._get_platform()
  File "/home/heimes/redhat/freeipa/ipaplatform/_importhook.py", line 63, in _get_platform
    importlib.import_module('ipaplatform.{}'.format(platform))
AttributeError: 'FailedImport' object has no attribute 'import_module'

closing per triage on Mon Nov 21

Metadata Update from @cheimes:
- Issue assigned to someone
- Issue set to the milestone: 0.0 NEEDS_TRIAGE

7 years ago

Login to comment on this ticket.

Metadata