When testing build in Fedora rawhide (pylint-1.6.4-1.fc26.noarch) I got the following errors/warnings:
Pylint is running, please wait ... ************* Module ipatests.test_xmlrpc.test_hbactest_plugin ipatests/test_xmlrpc/test_hbactest_plugin.py:220: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.sudocmdgroup ipaserver/plugins/sudocmdgroup.py:195: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.sudocmd ipaserver/plugins/sudocmd.py:203: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.selfservice ipaserver/plugins/selfservice.py:217: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.role ipaserver/plugins/role.py:252: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.realmdomains ipaserver/plugins/realmdomains.py:340: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.selinuxusermap ipaserver/plugins/selinuxusermap.py:569: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.pkinit ipaserver/plugins/pkinit.py:105: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.trust ipaserver/plugins/trust.py:1866: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.passwd ipaserver/plugins/passwd.py:150: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.otptoken ipaserver/plugins/otptoken.py:117: [C0201(consider-iterating-dictionary), _set_token_type] Consider iterating the dictionary directly instead of calling .keys()) ************* Module ipaserver.plugins.hostgroup ipaserver/plugins/hostgroup.py:316: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.hbacsvcgroup ipaserver/plugins/hbacsvcgroup.py:176: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.hbacsvc ipaserver/plugins/hbacsvc.py:152: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.idrange ipaserver/plugins/idrange.py:772: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.delegation ipaserver/plugins/delegation.py:220: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.hbacrule ipaserver/plugins/hbacrule.py:605: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.group ipaserver/plugins/group.py:692: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.batch ipaserver/plugins/batch.py:157: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipaserver.plugins.aci ipaserver/plugins/aci.py:343: [C0201(consider-iterating-dictionary), _aci_to_kw] Consider iterating the dictionary directly instead of calling .keys()) ipaserver/plugins/aci.py:791: [C0201(consider-iterating-dictionary), aci_find.execute] Consider iterating the dictionary directly instead of calling .keys()) ************* Module ipaserver.install.ipa_kra_install ipaserver/install/ipa_kra_install.py:229: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipapython.log_manager ipapython/log_manager.py:1560: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipapython.sysrestore ipapython/sysrestore.py:354: [C0201(consider-iterating-dictionary), StateFile.save] Consider iterating the dictionary directly instead of calling .keys()) ipapython/sysrestore.py:367: [C0201(consider-iterating-dictionary), StateFile.save] Consider iterating the dictionary directly instead of calling .keys()) ************* Module ipapython.dnssec.localhsm ipapython/dnssec/localhsm.py:171: [C0201(consider-iterating-dictionary), LocalHSM.import_public_key] Consider iterating the dictionary directly instead of calling .keys()) ipapython/dnssec/localhsm.py:181: [C0201(consider-iterating-dictionary), LocalHSM.import_private_key] Consider iterating the dictionary directly instead of calling .keys()) ************* Module ipapython.ipaldap ipapython/ipaldap.py:374: [C0201(consider-iterating-dictionary), LDAPEntry._add_attr_name] Consider iterating the dictionary directly instead of calling .keys()) ************* Module ipalib.request ipalib/request.py:80: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipa-otptoken-import install/tools/ipa-otptoken-import:24: [C0305(trailing-newlines), ] Trailing newlines) ************* Module examples doc/examples/examples.py:442: [C0305(trailing-newlines), ] Trailing newlines) ************* Module check-ra checks/check-ra.py:131: [C0305(trailing-newlines), ] Trailing newlines) ************* Module ipa-client-install client/ipa-client-install:805: [C0201(consider-iterating-dictionary), uninstall] Consider iterating the dictionary directly instead of calling .keys()) make: *** [Makefile:138: pylint] Error 1
We should investigate these errors and either fix them or update our pylintrc file to ignore them.
master:
Affects builds also on Fedora 25 where 4.4.2 is headed. We will need fix also for ipa-4-4
ipa-4-4:
Just disabling check in 4.4
Metadata Update from @mbabinsk: - Issue assigned to mbabinsk - Issue set to the milestone: FreeIPA 4.4.2
Login to comment on this ticket.