#6331 Reason is lost when CheckedIPAddress returns ValueError in ipa-client-install
Closed: Fixed None Opened 7 years ago by rcritten.

get_local_ipaddresses() is used to run through the list of interfaces and ipautil.CheckedIPAddress(ip) is called to evaluate whether the address is usable or not. If it isn't a ValueError is raised.

This ValueError is dropped. I think it should be raised so that the reason the address is unusable is recorded. The vast majority of the time this is perfectly useless information like "cannot use loopback IP address" and "cannot use link-local IP address" but occasionally it is helpful like "cannot use IANA reserved IP address".

I don't think this will pollute the logs much and it can probably also record the addresses being evaluated.


master:

  • d6f6a29 Add log messages for IP checks during client install

Metadata Update from @rcritten:
- Issue assigned to tkrizek
- Issue set to the milestone: FreeIPA 4.5

7 years ago

Login to comment on this ticket.

Metadata