#6219 Make cainstance.__spawn_instance() finish more gracefully for external CAs
Opened 7 years ago by stlaz. Modified 5 years ago

When creating CA instance of an external CA, the process is interrupted in the middle with an exception during the CAInstance.!__spawn_instance() execution as the following additional steps of instance creation are not necessary. cainstance.py:593

While the exception is masked to return value 0, different and more clean approach should be used.


Can we use more specific title. Title seems as refactoring of whole cainstance.py is required. But it seems that it is actually just about 1 sys.exit(0) call.

Do we already know what is the clean approach?

As sys.exit() calls were removed previously, currently an exception ScriptError is raised which does not seem very clean.

A better way would probably be to use the information about the type of external cainstance we're handling (self.external) and propagate this information to end more gracefully but it would better be investigated further.

The root issue here is that ipa-replica-installer advertises number of steps for both runs of the installer. In step 1, installer ends very soon which may confuse somebody. Instalelr should already know how many steps will be necessary so it should advertise that number (in both steps).

Metadata Update from @stlaz:
- Issue assigned to someone
- Issue set to the milestone: Future Releases

7 years ago

Seems to be back to sys.exit(0) in master (4.7.2+ish).

I think this will be resolved when HSM support is added and a pre-defined NSS cert database is provided to the installer. This eliminates the need to do multiple installation steps.

Metadata Update from @rcritten:
- Issue close_status updated to: None

5 years ago

Login to comment on this ticket.

Metadata