Issue #5892: Unused code in LDAPRemoveReverseMember - freeipa

freeipa

#5892 Unused code in LDAPRemoveReverseMember

Closed: Fixed None Opened 7 years ago by mbasti.

attrs_list is unused variable in LDAPRemoveReverseMember class

        if options.get('all', False):
            attrs_list = ['*'] + self.obj.default_attributes
        else:
            attrs_list = set(self.obj.default_attributes)
            if options.get('no_members', False):
                attrs_list.difference_update(self.obj.attribute_members)
            attrs_list = list(attrs_list)

I'm not sure if this is just forgotten code, or we have hidden bug there

Added in 4ad8055, usage removed in 3ba9cc8.
For me it looks like just forgotten code.

mbasti commented 7 years ago

It is unused code

mbasti commented 7 years ago

master:

c56d65b Removed dead code from LDAP{Remove,Add}ReverseMember

jcholast commented 7 years ago

master:

30d054a Revert "Removed dead code from LDAP{Remove,Add}ReverseMember"
427bbf6 The LDAP*ReverseMember shouldn't imply --all is always specified

Metadata Update from @mbasti:
- Issue assigned to stlaz
- Issue set to the milestone: FreeIPA 4.4

7 years ago

Metadata

Assignee

stlaz

Tags

None

Blocking

None

Depending on

None

Priority

normal

Milestone

FreeIPA 4.4

None

affects_doc

None

source

None

knownissue

None

type

defect

blockedby

None

test_case

None

component

IPA

blocking

None

on_review

keywords

easyfix

test_coverage

None

reviewer

None

external_tracker

None

rhbz

tester

None

changelog

None

design

None

freeipa

Source Code

#5892 Unused code in LDAPRemoveReverseMember Closed: Fixed None Opened 7 years ago by mbasti.

Metadata

#5892 Unused code in LDAPRemoveReverseMember

Closed: Fixed None Opened 7 years ago by mbasti.