#5585 python 3 incompatible exception handling in replicainstall.py
Closed: Fixed None Opened 8 years ago by mbabinsk.

There are some python 3 incompatible exception instantiations in {{{ipaserver/install/server/install.py}}}, namely on lines 335-355:

   messagebus = services.knownservices.messagebus
    try:
        messagebus.start()
    except Exception, e:
        print("Messagebus service unavailable: %s" % str(e))
        sys.exit(3)

    # Ensure that certmonger has been started at least once to generate the
    # cas files in /var/lib/certmonger/cas.
    cmonger = services.knownservices.certmonger
    try:
        cmonger.restart()
    except Exception, e:
        print("Certmonger service unavailable: %s" % str(e))
        sys.exit(3)

    try:
        cmonger.enable()
    except Exception, e:
        print("Failed to enable Certmonger: %s" % str(e))
        sys.exit(3)
...

and line 901:

    if not options.no_ntp:
        try:
            ipaclient.ntpconf.check_timedate_services()
        except ipaclient.ntpconf.NTPConflictingService, e:
            print("WARNING: conflicting time&date synchronization service '%s'"
                  " will" % e.conflicting_service)
            print("be disabled in favor of ntpd")
            print("")
        except ipaclient.ntpconf.NTPConfigurationError:
            pass

master:

  • 00c13fd fix Py3 incompatible exception instantiation in replica install code

ipa-4-3:

  • b14983b fix Py3 incompatible exception instantiation in replica install code

master:

  • 5062700 py3: Remove py3 incompatible exception handling

ipa-4-3:

  • 1181926 py3: Remove py3 incompatible exception handling

Metadata Update from @mbabinsk:
- Issue assigned to mbabinsk
- Issue set to the milestone: FreeIPA 4.3.1

7 years ago

Login to comment on this ticket.

Metadata