#4950 migrate-ds: slow add of users to default group
Closed: Fixed None Opened 9 years ago by pvoborni.

migrate-ds fetches ipa default group with members for setting a default group to users without a group.

Migration code checks if a user which should be added is not already a member of the group. The check is redundant given that the user should not be a member of any group and it still won't eliminate possible race conditions because anything could happen between search for users and search for group.

It also suffers from #4946 which makes whole migration quite slow and prone to fail.

Expected behavior:
migrate-ds should not do any processing of existing members which also means avoiding #4946. Generation of a mod list is enough.


master:

  • 2c1bca3 migrate-ds: optimize adding users to default group
  • fda9698 migrate-ds: skip default group option
  • a6ca980 migrate-ds: remove unused def_group_gid context property
  • c3d99a2 migrate-ds: optimize gid checks by utilizing dictionary nature of set
  • 3b0e81c migrate-ds: log migrated group members only on debug level
  • 91b39ac cli: differentiate Flag a Bool when autofill is set

Metadata Update from @pvoborni:
- Issue assigned to pvoborni
- Issue set to the milestone: FreeIPA 4.2

7 years ago

Login to comment on this ticket.

Metadata