#3855 Fix IPA 3.3 package issues
Closed: Fixed None Opened 7 years ago by mkosek.

Ticket was cloned from Red Hat Bugzilla (product Red Hat Enterprise Linux 7): Bug 995144

Description of problem:
Rob identified several issues with the new RHEL-7.0 package which should be
fixed before 7.0 GA:

1) /etc/tmpfiles.d/ipa.conf is missing the noreplace flag. Or do we assume
users won't modify this?

2) install/share/certmap.conf.template and install/share/05rfc2247.ldif have an
incorrect street address in the license. It should be 51 Franklin Street, Fifth
Floor, Boston, MA  02110-1301, USA
(http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)

3) In the trust subpackage the Description lines are longer than 80 chars and
need to be split better.

4) In python subpackage,
/usr/lib*/python*/site-packages/default_encoding_utf8.so is mode 0755 and an
automatic Provides is generated.

5) No man pages for ipa-test-task, ipa-test-config or ipa-run-tests in the
tests subpackage.

Version-Release number of selected component (if applicable):
ipa-3.3.0-1.el7

I just sent 2 patches fixing all issues except 5)

Replying to [ticket:3855 mkosek]:

1) /etc/tmpfiles.d/ipa.conf is missing the noreplace flag. Or do we assume
users won't modify this?

They shouldn't, if they want to add things they should add their own file.
I do not recall as anything should be really changed by users here. And we do not want this to break on pugrade if we change it as on a change it means we really need it deployed because the directories/files it creates are needed.
Maybe add a comment in the file that it should not be modified by users.

2) install/share/certmap.conf.template and install/share/05rfc2247.ldif have an
incorrect street address in the license. It should be 51 Franklin Street, Fifth
Floor, Boston, MA 02110-1301, USA
(http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)

Maybe we should stop copying so much boilerplate and alwys reference just the cOPYING file ? (As in literally: "LICENSE: See COPYING")

Replying to [comment:2 simo]:

Replying to [ticket:3855 mkosek]:

1) /etc/tmpfiles.d/ipa.conf is missing the noreplace flag. Or do we assume
users won't modify this?

They shouldn't, if they want to add things they should add their own file.
I do not recall as anything should be really changed by users here. And we do not want this to break on pugrade if we change it as on a change it means we really need it deployed because the directories/files it creates are needed.
Maybe add a comment in the file that it should not be modified by users.

I already raised the very same question to Rob, in the end we agreed on doing the (replace) to not discard potential user modifications - if user does not merge the new documentation, it's his problem.

2) install/share/certmap.conf.template and install/share/05rfc2247.ldif have an
incorrect street address in the license. It should be 51 Franklin Street, Fifth
Floor, Boston, MA 02110-1301, USA
(http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)

Maybe we should stop copying so much boilerplate and alwys reference just the cOPYING file ? (As in literally: "LICENSE: See COPYING")

Not sure, when you open such scripts or resources on your system, you do not instantly know what COPYING file to open (unless you can do rpm -qf, ...).

master:[[BR]]
b1474a5 Fix selected minor issues in the spec file and license[[BR]]
ba5311b Remove rpmlint warnings in spec file[[BR]]

ipa-3-3:[[BR]]
a17f739 Fix selected minor issues in the spec file and license[[BR]]
8b85bac Remove rpmlint warnings in spec file[[BR]]

Only item 5) is left to do. Petr please continue on that.

Man pages pushed.

master: f742520[[BR]]
ipa-3-3: 5945988

Metadata Update from @mkosek:
- Issue assigned to pviktori
- Issue set to the milestone: FreeIPA 3.3.x - 2013/08 (bug fixing)

4 years ago

Login to comment on this ticket.

Metadata