attachment
admiyo-freeipa-0058-password-dialog.patch

Including IRC conversation that captures state of the code review:

<edewata> ayoung, about patch #58, i think you should check for empty password too and reject it
<ayoung> edewata, I think that we should just let all policy be checked on the server side. THere might be use case for an admin to set an empty password
<edewata> ayoung, ok, but give it a try, when you get an error click retry, i think the error handler is not working properly
<ayoung> edewata, are you doing this as admin?
<ayoung> I just noticed a big bug running it that way
<edewata> ayoung, yes, changing admin's password. i saw your email
<ayoung> I suspect that what you are seeing is that I need to do something like $("password_1").val() || *
<ayoung> I'll add that, too
<edewata> ayoung, actually, this is what happens:
<edewata> ayoung, i entered empty passwords then click reset password, it will display the error dialog box then i click retry
<edewata> ayoung, the error dialog box disappeared for a second then reappeared
<edewata> ayoung, that's actually the correct behavior except that i thought i will be able to reenter a new password
<ayoung> yeah, because 'retry' sends the request again
<ayoung> cancel kicks you back to the pw screen
<ayoung> that is your code, the default error handler, I think
<edewata> ayoung, right. how about this, when you click reset password it closes the password dialog box, so if you get an error and retry you wouldn't see the password box?
<edewata> ayoung, what i mean is close the password box first, then submit the command
<edewata> what do you think?
<edewata> ayoung, and if you get an error and hit cancel the password box will reappear
<ayoung> edewata, sounds good. I'll try that out
<ayoung> ideally, we'd put a check in that the two passwords are the same before enabling the submit button, and put a message that they don't match...we can phase 2 that
<edewata> ayoung, ok

Going to close this, and make the comments above into RFEs