#3443 remove ip address family selection logic.
Closed: fixed 5 years ago Opened 11 years ago by jdennis.

This is a follow-up to ticket #2695. Ticket #2695 defeated the override we used to force on ip family selection but left much of the family selection code in place. This leads to confusing error messages, for instance if we can't connect the diagnostic message will allude to the fact it's an IPv6 address which likely has nothing to do with the issue, it just happened to be the last address it tried.

Also the connection logic is a bit convoluted to support family selection, and if for some reason the connection object get's reused it will use the wrong family because of retained state.

Since we really shouldn't be forcing family selection whatsoever and instead just iterating on the addresses returned by AddrInfo (see ticket #2695 for more explanation) there seems little point in maintaining complex code susceptible to misuse that emits misguided diagnostics and which we should never be using.

It should be removed and simplified, I think the only reason it was originally introduced was due to a misunderstanding.


Metadata Update from @jdennis:
- Issue assigned to someone
- Issue set to the milestone: Future Releases

7 years ago

The code in question was refactored out so this ticket no longer applies. Closing.

Metadata Update from @rcritten:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

5 years ago

Login to comment on this ticket.

Metadata