Description of problem:
ipa permission-add throws internal server error when --addattr or --setattr is
blank
# ipa permission-add TestPermission --permissions="write" --type=hostgroup
--attr=carlicense --addattr=
And
# ipa permission-add TestPermission --permissions="write" --type=hostgroup
--attr=carlicense --setattr=""

throw
ipa: ERROR: an internal error has occurred

Version-Release number of selected component (if applicable):
ipa-server-2.2.0-11.el6.x86_64


How reproducible:
always

Steps to Reproduce:
1.# ipa permission-add TestPermission --permissions="write" --type=hostgroup
--attr=carlicense --addattr=


Actual results:
ipa: ERROR: an internal error has occurred


Expected results:
Better error

Additional info:
[Thu Apr 26 08:27:15 2012] [error] ipa: INFO: admin@TESTRELM.COM:
privilege_add(u'Add User with blank attr', description=u'Add User with blank
attr', setattr=None, all=False, raw=False, version=u'2.34'): TypeError
[Thu Apr 26 08:32:08 2012] [error] ipa: ERROR: non-public: TypeError: expected
string or buffer
[Thu Apr 26 08:32:08 2012] [error] Traceback (most recent call last):
[Thu Apr 26 08:32:08 2012] [error]   File
"/usr/lib/python2.6/site-packages/ipaserver/rpcserver.py", line 320, in
wsgi_execute
[Thu Apr 26 08:32:08 2012] [error]     result = self.Command[name](*args,
**options)
[Thu Apr 26 08:32:08 2012] [error]   File
"/usr/lib/python2.6/site-packages/ipalib/frontend.py", line 438, in __call__
[Thu Apr 26 08:32:08 2012] [error]     ret = self.run(*args, **options)
[Thu Apr 26 08:32:08 2012] [error]   File
"/usr/lib/python2.6/site-packages/ipalib/frontend.py", line 716, in run
[Thu Apr 26 08:32:08 2012] [error]     return self.execute(*args, **options)
[Thu Apr 26 08:32:08 2012] [error]   File
"/usr/lib/python2.6/site-packages/ipalib/plugins/baseldap.py", line 978, in
execute
[Thu Apr 26 08:32:08 2012] [error]     self.process_attr_options(entry_attrs,
None, keys, options)
[Thu Apr 26 08:32:08 2012] [error]   File
"/usr/lib/python2.6/site-packages/ipalib/plugins/baseldap.py", line 853, in
process_attr_options
[Thu Apr 26 08:32:08 2012] [error]     adddict =
self._convert_2_dict(options.get('addattr', []))
[Thu Apr 26 08:32:08 2012] [error]   File
"/usr/lib/python2.6/site-packages/ipalib/plugins/baseldap.py", line 806, in
_convert_2_dict
[Thu Apr 26 08:32:08 2012] [error]     m =
re.match("\\s*(.*?)\\s*=\\s*(.*?)\\s*$", a)
[Thu Apr 26 08:32:08 2012] [error]   File "/usr/lib64/python2.6/re.py", line
137, in match
[Thu Apr 26 08:32:08 2012] [error]     return _compile(pattern,
flags).match(string)
[Thu Apr 26 08:32:08 2012] [error] TypeError: expected string or buffer
[Thu Apr 26 08:32:08 2012] [error] ipa: INFO: admin@TESTRELM.COM:
permission_add(u'TestPermission', permissions=(u'write',),
attrs=(u'carlicense',), type=u'hostgroup', addattr=None, all=False, raw=False,
version=u'2.34'): TypeError