Establish Codeing conventions and standards get style checker and formatter
Standards doc for Javascript/JQuery is published, now we need to meet it.
Coding conventions have been established and are being followed.
Not quite ready to close this ticket. THe idea is that we are going to run our code through JSLint. While we are meeting coding standards and conventions, we have much code that still need to be modified. Probably the sinlge larges example is that we have many global ipa_ functions that need to be changed to IPA. functions, to avoid polluting the global namespace.
One structural issue that has kept us from integrating JSLint onto the build is that it is a web application, and the licensing is such that Fedora can't include it. Also, it assumes everything is in one large file, and we've modularized our code into separate files. However, we can still work toward meeting this by doing a script that concats all of our files into one in the order that they appear in index.html and run the resultant file through JSLint. THen, we can choose to selectively ignore rules that we have decent reason to overrule, but it should be a deliberate decision.
Biggest thing left is remove all of the global variables. Renaming the ticket. There are places where the 'var' keyword is missing, which will also pollute the global namespace.
IPA (valid and required)
BEGIN_CERTIFICATE BEGIN_CERTIFICATE_REQUEST CERTIFICATE_STATUS_MISSING CERTIFICATE_STATUS_REVOKED CERTIFICATE_STATUS_VALID CRL_REASON END_CERTIFICATE END_CERTIFICATE_REQUEST _search_a_pkey_template _search_td_template admin_tab_set nav_container nav_tabs_lists onhashchange option_temp select_temp self_serv_tab_set states window_hash_cache _ipa_create_remove_link _ipa_remove_on_click _nav_update_tabs bulk_associator certificate_get_dialog certificate_parse_dn certificate_request_dialog certificate_restore_dialog certificate_revoke_dialog certificate_status_widget certificate_view_dialognav_create_tab_div host_certificate_status_widget host_provisioning_status_widget nav_create nav_create_tab_div nav_create_tab_li nav_generate_tabs nav_get_state nav_push_state nav_remove_state nav_update_tabs resetpwd_on_click search_generate_checkbox_td search_generate_td search_generate_tr serial_associator service_certificate_status_widget service_host_load service_provisioning_status_widget service_service_load unimplemented_tab user_password_load user_state_load user_status_widget
All IPA global identifiers moved to IPA (sub-)namespace.
Global identifiers fixed in b7700ea. I think we can close this one.
Metadata Update from @admiyo: - Issue assigned to mkosek - Issue set to the milestone: FreeIPA 2.0.2 RC2 (bug fixing)
Login to comment on this ticket.