#1596 Missing message summary while removing sudooption.
Closed: Fixed None Opened 8 years ago by dpal.

https://bugzilla.redhat.com/show_bug.cgi?id=729246

Description of problem:


Version-Release number of selected component (if applicable):
ipa-admintools-2.0.99-8.20110804T1127zgiteb0454d.el6.x86_64

How reproducible:


Steps to Reproduce:
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: [   LOG    ] :: sudorule-remove-option_002: ipa sudorule-remove-option
sudorule1 --sudooption="logfile=/var/log/sudolog"
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [   PASS   ] :: Running 'ipa sudorule-remove-option sudorule1
--sudooption=logfile=/var/log/sudolog >
/tmp/tmp.LyEgVu1CxY/sudorule-remove-option_002.txt 2>&1'
:: [   FAIL   ] :: File '/tmp/tmp.LyEgVu1CxY/sudorule-remove-option_002.txt'
should contain 'Removed option "logfile=/var/log/sudolog" from Sudo rule
"sudorule1"' 
  Rule name: sudorule1
  Enabled: TRUE
  Sudo Option: env_keep = LANG LC_ADDRESS LC_CTYPE LC_COLLATE LC_IDENTIFICATION
LC_MEASUREMENT LC_MESSAGES LC_MONETARY LC_NAME LC_NUMERIC LC_PAPER LC_TELEPHONE
LC_TIME LC_ALL LANGUAGE LINGUAS XDG_SESSION_COOKIE, !authenticate
:: [   PASS   ] :: Running 'cat
/tmp/tmp.LyEgVu1CxY/sudorule-remove-option_002.txt'

Actual results:
Missing message summary while removing a sudooption.

Expected results:
Message summary should be displayed.

Additional info:
Marking this as REGRESSION since this test passed in
ipa-admintools-2.0.0-25.el6.x86_64.

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: [   LOG    ] :: sudorule-remove-option_002: ipa sudorule-remove-option
sudorule1 --sudooption="logfile=/var/log/sudolog"
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [   PASS   ] :: Running 'ipa sudorule-remove-option sudorule1
--sudooption=logfile=/var/log/sudolog >
/tmp/tmp.oQU4qexF3t/sudorule-remove-option_002.txt 2>&1'
:: [   PASS   ] :: File '/tmp/tmp.oQU4qexF3t/sudorule-remove-option_002.txt'
should contain 'Removed option "logfile=/var/log/sudolog" from Sudo rule
"sudorule1"'
-----------------------
sudorule-remove-option:
-----------------------
--------------------------------------------------------------------
Removed option "logfile=/var/log/sudolog" from Sudo rule "sudorule1"
--------------------------------------------------------------------
:: [   PASS   ] :: Running 'cat
/tmp/tmp.oQU4qexF3t/sudorule-remove-option_002.txt'

This regression was caused by 44cdf8e. We should decide what is the desired behavior, because currently there is no summary for all following sudorule commands:

  sudorule-add-allow-command     Add commands and sudo command groups affected by Sudo Rule.
  sudorule-add-deny-command      Add commands and sudo command groups affected by Sudo Rule.
  sudorule-add-host              Add hosts and hostgroups affected by Sudo Rule.
  sudorule-add-option            Add an option to the Sudo rule.
  sudorule-add-runasgroup        Add group for Sudo to execute as.
  sudorule-add-runasuser         Add users and groups for Sudo to execute as.
  sudorule-add-user              Add users and groups affected by Sudo Rule.
  sudorule-disable               Disable a Sudo rule.
  sudorule-enable                Enable a Sudo rule.
  sudorule-remove-allow-command  Remove commands and sudo command groups affected by Sudo Rule.
  sudorule-remove-deny-command   Remove commands and sudo command groups affected by Sudo Rule.
  sudorule-remove-host           Remove hosts and hostgroups affected by Sudo Rule.
  sudorule-remove-option         Remove an option from Sudo rule.
  sudorule-remove-runasgroup     Remove group for Sudo to execute as.
  sudorule-remove-runasuser      Remove users and groups for Sudo to execute as.
  sudorule-remove-user           Remove users and groups affected by Sudo Rule.

Metadata Update from @dpal:
- Issue assigned to mkosek
- Issue set to the milestone: FreeIPA 2.1.1 (bug fixing)

2 years ago

Login to comment on this ticket.

Metadata