Pylint output on the master branch (not including false positives):
makeapi:146: [E0601, validate_api] Using variable 'found_args' before assignment makeapi:146: [E0601, validate_api] Using variable 'expected_args' before assignment makeapi:147: [E0601, validate_api] Using variable 'found_options' before assignment makeapi:147: [E0601, validate_api] Using variable 'expected_options' before assignment makeapi:148: [E0601, validate_api] Using variable 'found_output' before assignment makeapi:148: [E0601, validate_api] Using variable 'expected_output' before assignment ipaserver/rpcserver.py:208: [E1101, WSGIExecutioner.wsgi_execute] Instance of 'WSGIExecutioner' has no 'content_type' member ipaserver/rpcserver.py:246: [E1101, WSGIExecutioner.__call__] Instance of 'WSGIExecutioner' has no 'content_type' member ipaserver/install/service.py:171: [E1101, Service.move_service] Instance of 'Service' has no 'realm' member ipaserver/install/service.py:171: [E1101, Service.move_service] Instance of 'Service' has no 'suffix' member ipaserver/install/service.py:178: [E1101, Service.move_service] Instance of 'Service' has no 'suffix' member ipaserver/install/service.py:179: [E1101, Service.move_service] Instance of 'Service' has no 'suffix' member ipaserver/install/service.py:199: [E1101, Service.add_simple_service] Instance of 'Service' has no 'suffix' member ipaserver/install/service.py:200: [E1101, Service.add_simple_service] Instance of 'Service' has no 'suffix' member ipaserver/install/service.py:230: [E1101, Service.add_cert_to_service] Instance of 'Service' has no 'principal' member ipaserver/install/service.py:230: [E1101, Service.add_cert_to_service] Instance of 'Service' has no 'suffix' member ipaserver/install/service.py:235: [E1101, Service.add_cert_to_service] Instance of 'Service' has no 'principal' member ipapython/nsslib.py:146: [E1101, NSSAddressFamilyFallback._connect_socket_family] Module 'nss.io' has no 'addr_family_name' member ipapython/nsslib.py:148: [E1101, NSSAddressFamilyFallback._connect_socket_family] Module 'nss.io' has no 'AddrInfo' member ipapython/nsslib.py:152: [E1101, NSSAddressFamilyFallback._connect_socket_family] Module 'nss.io' has no 'addr_family_name' member ipapython/nsslib.py:295: [E1101, NSPRConnection._create_socket] Instance of '_socketobject' has no 'set_hostname' member ipalib/text.py:167: [E1101, LazyText.__eq__] Instance of 'LazyText' has no 'args' member ipalib/frontend.py:906: [E0102, Command.output_for_cli] method already defined line 389 ipalib/parameters.py:1167: [E1101, Data._rule_pattern] Instance of 'Data' has no 're' member ipalib/parameters.py:1168: [E1101, Data._rule_pattern] Instance of 'Data' has no 're_errmsg' member ipalib/parameters.py:1169: [E1101, Data._rule_pattern] Instance of 'Data' has no 're_errmsg' member ipalib/aci.py:61: [E1101, ACI.__getitem__] Instance of 'ACI' has no 'source_group' member ipalib/aci.py:63: [E1101, ACI.__getitem__] Instance of 'ACI' has no 'dest_group' member install/po/test_i18n.py:83: [E0602, main] Undefined variable '_' install/po/test_i18n.py:101: [E0602, main] Undefined variable '_' install/tools/ipa-nis-manage:86: [E0602, main] Undefined variable 'os'
So far patches are ready for everything except:
ipapython/nsslib.py:146: [E1101, NSSAddressFamilyFallback._connect_socket_family] Module 'nss.io' has no 'addr_family_name' member ipapython/nsslib.py:148: [E1101, NSSAddressFamilyFallback._connect_socket_family] Module 'nss.io' has no 'AddrInfo' member ipapython/nsslib.py:152: [E1101, NSSAddressFamilyFallback._connect_socket_family] Module 'nss.io' has no 'addr_family_name' member ipapython/nsslib.py:295: [E1101, NSPRConnection._create_socket] Instance of '_socketobject' has no 'set_hostname' member install/po/test_i18n.py:83: [E0602, main] Undefined variable '_' install/po/test_i18n.py:101: [E0602, main] Undefined variable '_' install/tools/ipa-nis-manage:86: [E0602, main] Undefined variable 'os'
These are non-issues appearing only when using python-nss < 0.11:
ipapython/nsslib.py:146: [E1101, NSSAddressFamilyFallback._connect_socket_family] Module 'nss.io' has no 'addr_family_name' member ipapython/nsslib.py:148: [E1101, NSSAddressFamilyFallback._connect_socket_family] Module 'nss.io' has no 'AddrInfo' member ipapython/nsslib.py:152: [E1101, NSSAddressFamilyFallback._connect_socket_family] Module 'nss.io' has no 'addr_family_name' member
This one is an issue in NSPRConnection, which is used only in NSPRHTTP, which isn't used anywhere at all:
ipapython/nsslib.py:295: [E1101, NSPRConnection._create_socket] Instance of '_socketobject' has no 'set_hostname' member
Does NSPRConnection and NSPRHTTP serve any purpose at all? Or can we get rid of them?
Fixed.
[df81207][[BR]] [267f39d][[BR]] [b007233][[BR]] [f8cb129][[BR]] [c31d7b9][[BR]] [5700920]
Metadata Update from @jcholast: - Issue assigned to jcholast - Issue set to the milestone: FreeIPA 2.1 - 2011/08 (Final)
Login to comment on this ticket.