ffcbb83 ipasam: use SID formatting calls to libsss_idmap

1 file Authored by abbra 5 years ago, Committed by cheimes 5 years ago,
    ipasam: use SID formatting calls to libsss_idmap
    
    Samba 4.10 moved away to private libraries two functions we used to
    convert a binary SID structre to strings:
     - sid_talloc_string()
     - sid_string_dbg()
    
    We already used libsss_idmap to convert textual representation of SIDs
    to a binary one, use the reverse function too.
    
    libsss_idmap code operates on talloc structures, so we need to adopt a
    bit a place where sid_string_dbg() was used because it assumed a static
    buffer was provided by sid_string_dbg().
    
    Finally, sid_talloc_string()'s replacement moves allocated memory to the
    right context so that a memory will be freed earlier. Our SSSD idmap
    context is a long-living one while in all cases where we were using
    sid_talloc_string() we free the context much earlier.
    
    Resolves: https://pagure.io/freeipa/issue/7893
    Reviewed-By: Christian Heimes <cheimes@redhat.com>
    
        
file modified
+37 -15