From fb975bba2076758f0615dae042aed2cde705a1b0 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Jul 28 2014 08:20:15 +0000 Subject: webui: internet explorer fixes Fixed: 1. IE doesn't support value 'initial' in CSS rule. 2. setting innerHTML='' also destroys content of child nodes in LoginScreen in IE -> reattached buttons have no text. Reviewed-By: Endi Sukma Dewata --- diff --git a/install/ui/less/widgets.less b/install/ui/less/widgets.less index c21a163..7876307 100644 --- a/install/ui/less/widgets.less +++ b/install/ui/less/widgets.less @@ -4,7 +4,7 @@ .global-activity-indicator { - bottom: initial; + bottom: auto; height: auto; background-color: rgba(0, 0, 0, 0.3); color: white; diff --git a/install/ui/src/freeipa/widgets/LoginScreen.js b/install/ui/src/freeipa/widgets/LoginScreen.js index 3e09864..e7e1b02 100644 --- a/install/ui/src/freeipa/widgets/LoginScreen.js +++ b/install/ui/src/freeipa/widgets/LoginScreen.js @@ -231,7 +231,13 @@ define(['dojo/_base/declare', refresh: function() { if (this.buttons_node) { - this.buttons_node.innerHTML = ""; + // detach button nodes politely + // hard methods like `innerHTML=''` might have undesired + // consequences, e.g., removal of children's content in IE + var bn = this.buttons_node; + while (bn.firstChild) { + bn.removeChild(bn.firstChild); + } } if (this.view === 'reset') { this.show_reset_view();