From f2ec44f2705fe87b71c6290ae8b35bc0a05f68d2 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Jan 31 2017 09:44:42 +0000 Subject: Use proper logging for error messages https://fedorahosted.org/freeipa/ticket/6588r Reviewed-By: Stanislav Laznicka --- diff --git a/ipaserver/install/replication.py b/ipaserver/install/replication.py index c4260dd..1f13783 100644 --- a/ipaserver/install/replication.py +++ b/ipaserver/install/replication.py @@ -176,7 +176,7 @@ def wait_for_entry(connection, dn, timeout=7200, attr='', quiet=True): except errors.NotFound: pass # no entry yet except Exception as e: # badness - print("\nError reading entry", dn, e) + root_logger.error("Error reading entry %s: %s", dn, e) break if not entry: if not quiet: @@ -185,11 +185,13 @@ def wait_for_entry(connection, dn, timeout=7200, attr='', quiet=True): time.sleep(1) if not entry and int(time.time()) > timeout: - print("\nwait_for_entry timeout for %s for %s" % (connection, dn)) + root_logger.error( + "wait_for_entry timeout for %s for %s", connection, dn) elif entry and not quiet: - print("\nThe waited for entry is:", entry) + root_logger.error("The waited for entry is: %s", entry) elif not entry: - print("\nError: could not read entry %s from %s" % (dn, connection)) + root_logger.error( + "Error: could not read entry %s from %s", dn, connection) class ReplicationManager(object):