e565809 Fix pylint 2.0 return-related violations

27 files Authored by abiagion 5 years ago, Committed by cheimes 5 years ago,
    Fix pylint 2.0 return-related violations
    
    Aiming to support pylint 2.0 some functions and methods must have their
    return statements updated in order to fix two new violations:
    
    - `useless-return` (R1711):
      Useless return at end of function or method Emitted when a single
      "return" or "return None" statement is found at the end of function
      or method definition. This statement can safely be removed because
      Python will implicitly return None
    
    - `inconsistent-return-statements` (R1710):
      Either all return statements in a function should return an
      expression, or none of them should. According to PEP8, if any return
      statement returns an expression, any return statements where no value
      is returned should explicitly state this as return None, and an
      explicit return statement should be present at the end of the
      function (if reachable)
    
    Issue: https://pagure.io/freeipa/issue/7614
    
    Signed-off-by: Armando Neto <abiagion@redhat.com>
    Reviewed-By: Christian Heimes <cheimes@redhat.com>
    Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
    
        
file modified
+1 -1
file modified
+0 -1
file modified
+8 -12
file modified
+2 -3
file modified
+2 -1
file modified
+1 -0
file modified
+2 -2
file modified
+1 -1
file modified
+1 -0
file modified
+1 -0
file modified
+2 -2
file modified
+11 -7
file modified
+1 -1
file modified
+4 -4
file modified
+2 -0