e38c13e ipa-kdb: unexpected error code in 'ipa_kdb_audit_as_req' triggers a message

3 files Authored by mbabinsk 9 years ago, Committed by mkosek 9 years ago,
    ipa-kdb: unexpected error code in 'ipa_kdb_audit_as_req' triggers a message
    
    This patch is related this defect reported by covscan on FreeIPA master:
    
    """
    Error: DEADCODE (CWE-561):
    /daemons/ipa-kdb/ipa_kdb_audit_as.c:42: cond_const: Condition "error_code !=
    -1765328353L", taking false branch. Now the value of "error_code" is equal to
    -1765328353.
    /daemons/ipa-kdb/ipa_kdb_audit_as.c:42: cond_const: Condition
    "error_code != -1765328360L", taking false branch. Now the value of
    "error_code" is equal to -1765328360.
    /daemons/ipa-kdb/ipa_kdb_audit_as.c:42:
    cond_const: Condition "error_code != 0", taking false branch. Now the value of
    "error_code" is equal to 0.
    /daemons/ipa-kdb/ipa_kdb_audit_as.c:71:
    intervals: When switching on "error_code", the value of "error_code" must be
    in one of the following intervals: {[-1765328360,-1765328360],
    [-1765328353,-1765328353], [0,0]}.
    /daemons/ipa-kdb/ipa_kdb_audit_as.c:71:
    dead_error_condition: The switch value "error_code" cannot reach the default
    case.
    /daemons/ipa-kdb/ipa_kdb_audit_as.c:123: dead_error_begin: Execution
    cannot reach this statement: "default:".
    """
    
    This patch is a part of series related to
    https://fedorahosted.org/freeipa/ticket/4795.
    
    Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
    
        
file modified
+2 -0