From d94a2aa185defba38f2bbe2c5ee28f9b9defc0f2 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka Date: Nov 10 2016 17:58:38 +0000 Subject: Coverity - true branch can't be executed The 'result' variable is always false because of previous condition. Therefore there is direct assignment. Reviewed-By: Petr Vobornik --- diff --git a/install/ui/src/freeipa/rpc.js b/install/ui/src/freeipa/rpc.js index 2eed6cc..f3cc48c 100644 --- a/install/ui/src/freeipa/rpc.js +++ b/install/ui/src/freeipa/rpc.js @@ -636,7 +636,8 @@ rpc.batch_command = function(spec) { if (!result) { name = text.get('@i18n:errors.internal_error', 'Internal Error')+' '+xhr.status; - message = result ? xhr.statusText : text.get('@i18n:errors.internal_error', 'Internal Error'); + message = xhr ? xhr.statusText : + text.get('@i18n:errors.internal_error', 'Internal Error'); that.errors.add(command, name, message, text_status);