From c8bcf4287f9aa881a6517f26adce001b3dbcd1c2 Mon Sep 17 00:00:00 2001
From: Petr Viktorin <pviktori@redhat.com>
Date: Apr 28 2016 14:22:07 +0000
Subject: sysrestore: Iterate over a list of dict keys


In Python 3, dict.keys() returns a key view. It is not safe to delete
dict keys when iterating over this view.

Convert the keys to list first.

Part of the work for https://fedorahosted.org/freeipa/ticket/4985

Reviewed-By: Martin Basti <mbasti@redhat.com>

---

diff --git a/ipapython/sysrestore.py b/ipapython/sysrestore.py
index 9bb9e76..954d788 100644
--- a/ipapython/sysrestore.py
+++ b/ipapython/sysrestore.py
@@ -348,7 +348,7 @@ class StateFile:
         """
         root_logger.debug("Saving StateFile to '%s'", self._path)
 
-        for module in self.modules.keys():
+        for module in list(self.modules.keys()):
             if len(self.modules[module]) == 0:
                 del self.modules[module]