From c7ce801b590e29263e9b1904995c603735007771 Mon Sep 17 00:00:00 2001 From: Alexander Bokovoy Date: Mar 02 2021 12:44:36 +0000 Subject: ipa-kdb: add missing prototypes On Fedora 33 GCC defaults to -Wmissing-prototypes and emits warnings about function prototypes missing. If -Werror is specified, this breaks compilation. We also default to -Werror=implicit-function-declaration Signed-off-by: Alexander Bokovoy Reviewed-By: Robbie Harwood Reviewed-By: Rob Crittenden --- diff --git a/daemons/ipa-kdb/ipa_kdb_kdcpolicy.c b/daemons/ipa-kdb/ipa_kdb_kdcpolicy.c index a89f8bb..aa61a2d 100644 --- a/daemons/ipa-kdb/ipa_kdb_kdcpolicy.c +++ b/daemons/ipa-kdb/ipa_kdb_kdcpolicy.c @@ -14,6 +14,10 @@ #define ONE_DAY_SECONDS (24 * 60 * 60) #define JITTER_WINDOW_SECONDS (1 * 60 * 60) +krb5_error_code kdcpolicy_ipakdb_initvt(krb5_context context, + int maj_ver, int min_ver, + krb5_plugin_vtable vtable); + static void jitter(krb5_deltat baseline, krb5_deltat *lifetime_out) { diff --git a/daemons/ipa-kdb/ipa_kdb_mspac.c b/daemons/ipa-kdb/ipa_kdb_mspac.c index 9691b14..47b12a1 100644 --- a/daemons/ipa-kdb/ipa_kdb_mspac.c +++ b/daemons/ipa-kdb/ipa_kdb_mspac.c @@ -2408,9 +2408,10 @@ void ipadb_mspac_struct_free(struct ipadb_mspac **mspac) *mspac = NULL; } -krb5_error_code ipadb_adtrusts_fill_sid_blacklist(char **source_sid_blacklist, - struct dom_sid **result_sids, - int *result_length) +static krb5_error_code +ipadb_adtrusts_fill_sid_blacklist(char **source_sid_blacklist, + struct dom_sid **result_sids, + int *result_length) { int len, i; char **source; @@ -2441,9 +2442,10 @@ krb5_error_code ipadb_adtrusts_fill_sid_blacklist(char **source_sid_blacklist, return 0; } -krb5_error_code ipadb_adtrusts_fill_sid_blacklists(struct ipadb_adtrusts *adtrust, - char **sid_blocklist_incoming, - char **sid_blocklist_outgoing) +static krb5_error_code +ipadb_adtrusts_fill_sid_blacklists(struct ipadb_adtrusts *adtrust, + char **sid_blocklist_incoming, + char **sid_blocklist_outgoing) { krb5_error_code kerr; @@ -2464,7 +2466,8 @@ krb5_error_code ipadb_adtrusts_fill_sid_blacklists(struct ipadb_adtrusts *adtrus return 0; } -krb5_error_code ipadb_mspac_check_trusted_domains(struct ipadb_context *ipactx) +static krb5_error_code +ipadb_mspac_check_trusted_domains(struct ipadb_context *ipactx) { char *attrs[] = { NULL }; char *filter = "(objectclass=ipaNTTrustedDomain)"; @@ -2509,7 +2512,8 @@ static void ipadb_free_sid_blacklists(char ***sid_blocklist_incoming, char ***si } } -krb5_error_code ipadb_mspac_get_trusted_domains(struct ipadb_context *ipactx) +static krb5_error_code +ipadb_mspac_get_trusted_domains(struct ipadb_context *ipactx) { struct ipadb_adtrusts *t; LDAP *lc = NULL; diff --git a/daemons/ipa-kdb/ipa_kdb_mspac_private.h b/daemons/ipa-kdb/ipa_kdb_mspac_private.h index d23a14a..8c8a3a0 100644 --- a/daemons/ipa-kdb/ipa_kdb_mspac_private.h +++ b/daemons/ipa-kdb/ipa_kdb_mspac_private.h @@ -53,3 +53,7 @@ struct ipadb_adtrusts { int string_to_sid(const char *str, struct dom_sid *sid); char *dom_sid_string(TALLOC_CTX *memctx, const struct dom_sid *dom_sid); +krb5_error_code filter_logon_info(krb5_context context, TALLOC_CTX *memctx, + krb5_data realm, struct PAC_LOGON_INFO_CTR *info); +void get_authz_data_types(krb5_context context, krb5_db_entry *entry, + bool *_with_pac, bool *_with_pad); \ No newline at end of file