From b54ceae9616b733c35ce7928309b8ab93527110b Mon Sep 17 00:00:00 2001 From: Pavel Vomacka Date: Apr 25 2017 10:23:12 +0000 Subject: WebUI: Coverity - add explicit window object to alert methods All calls of alert were without explicit object. This commit adds explicit object window. Reviewed-By: Tomas Krizek --- diff --git a/install/ui/src/freeipa/association.js b/install/ui/src/freeipa/association.js index 27a76a5..dcb78f1 100644 --- a/install/ui/src/freeipa/association.js +++ b/install/ui/src/freeipa/association.js @@ -116,7 +116,7 @@ IPA.serial_associator = function(spec) { batch.add_command(command); } - //alert(JSON.stringify(command.to_json())); + //window.alert(JSON.stringify(command.to_json())); batch.execute(); }; @@ -154,7 +154,7 @@ IPA.bulk_associator = function(spec) { command.set_option(that.other_entity.name, that.values); - //alert(JSON.stringify(command.to_json())); + //window.alert(JSON.stringify(command.to_json())); command.execute(); }; @@ -731,7 +731,7 @@ IPA.association_table_widget = function (spec) { if (!selected_values.length) { var message = text.get('@i18n:dialogs.remove_empty'); - alert(message); + window.alert(message); return; } @@ -1268,7 +1268,7 @@ exp.association_facet = IPA.association_facet = function (spec, no_init) { if (!values.length) { var message = text.get('@i18n:dialogs.remove_empty'); - alert(message); + window.alert(message); return; } @@ -1579,7 +1579,7 @@ exp.attribute_facet = IPA.attribute_facet = function(spec, no_init) { if (!selected_values.length) { var message = text.get('@i18n:dialogs.remove_empty'); - alert(message); + window.alert(message); return; } diff --git a/install/ui/src/freeipa/dns.js b/install/ui/src/freeipa/dns.js index 1ea3aaa..1be8513 100644 --- a/install/ui/src/freeipa/dns.js +++ b/install/ui/src/freeipa/dns.js @@ -1949,7 +1949,7 @@ IPA.dns.record_type_table_widget = function(spec) { if (!selected_values.length) { var message = text.get('@i18n:dialogs.remove_empty'); - alert(message); + window.alert(message); return; } diff --git a/install/ui/src/freeipa/search.js b/install/ui/src/freeipa/search.js index e2fbf44..fd7174d 100644 --- a/install/ui/src/freeipa/search.js +++ b/install/ui/src/freeipa/search.js @@ -213,7 +213,7 @@ IPA.search_facet = function(spec, no_init) { var title; if (!values.length) { title = text.get('@i18n:dialogs.remove_empty'); - alert(title); + window.alert(title); return null; } diff --git a/install/ui/src/freeipa/sudo.js b/install/ui/src/freeipa/sudo.js index 44c9a20..733e411 100644 --- a/install/ui/src/freeipa/sudo.js +++ b/install/ui/src/freeipa/sudo.js @@ -860,7 +860,7 @@ IPA.sudo.options_section = function(spec) { if (!values.length) { var message = text.get('@i18n:dialogs.remove_empty'); - alert(message); + window.alert(message); return; } @@ -952,4 +952,4 @@ exp.register = function() { phases.on('registration', exp.register); return exp; -}); \ No newline at end of file +}); diff --git a/install/ui/src/freeipa/widget.js b/install/ui/src/freeipa/widget.js index b7a6504..495e294 100644 --- a/install/ui/src/freeipa/widget.js +++ b/install/ui/src/freeipa/widget.js @@ -4331,7 +4331,7 @@ IPA.attribute_table_widget = function(spec) { if (!selected_values.length) { var message = text.get('@i18n:dialogs.remove_empty'); - alert(message); + window.alert(message); return null; }