b24feb4 ipatests: fix test_replica_promotion.py::TestHiddenReplicaPromotion

Authored and Committed by frenaud 4 years ago
    ipatests: fix test_replica_promotion.py::TestHiddenReplicaPromotion
    
    The test test_replica_promotion.py::TestHiddenReplicaPromotion randomly
    fails in nightly_f29.
    
    The test is checking that a given IP address is not in the DNS records
    for the domain. When we are unlucky, we may come up with the following
    situation:
    - IP address that is unexpected: 192.168.121.25
    - IP address that is found for the DNS record: 192.168.121.254
    
    As 192.168.121.25 is a substring of 192.168.121.254, the test wrongly considers that the unexpected address was found.
    Extract of the log:
        for host in hosts_unexpected:
            value = host.hostname if rtype == 'SRV' else host.ip
    >       assert value not in txt
    E       AssertionError: assert '192.168.121.25' not in 'ipa-ca.ipa.test. 1 IN A 192.168.121.254'
    E         '192.168.121.25' is contained here:
    E           ipa-ca.ipa.test. 1 IN A 192.168.121.254
    E         ?                         ++++++++++++++
    
    This happens because the test is comparing the content of the output as a
    string. The fix is extracting the exact hostname/IP address from the
    record instead.
    
    Fixes: https://pagure.io/freeipa/issue/8070
    Reviewed-By: Rob Crittenden <rcritten@redhat.com>