From 9fd1981ae8abf720f5234b6049c9beabbb1f2211 Mon Sep 17 00:00:00 2001
From: Jan Cholasta <jcholast@redhat.com>
Date: Nov 11 2016 11:17:25 +0000
Subject: install: introduce updated knob constructor


Add new knob() knob constructor. Keep the old Knob() constructor for
backward compatibility with old code.

https://fedorahosted.org/freeipa/ticket/6392

Reviewed-By: Martin Basti <mbasti@redhat.com>

---

diff --git a/ipapython/install/core.py b/ipapython/install/core.py
index 0a208ca..c3dc908 100644
--- a/ipapython/install/core.py
+++ b/ipapython/install/core.py
@@ -141,7 +141,7 @@ class KnobBase(PropertyBase):
         return cls
 
 
-def Knob(type_or_base, default=_missing, sensitive=_missing,
+def knob(type_or_base, default=_missing, sensitive=_missing,
          deprecated=_missing, description=_missing, cli_positional=_missing,
          cli_name=_missing, cli_short_name=_missing, cli_aliases=_missing,
          cli_metavar=_missing):
@@ -175,6 +175,22 @@ def Knob(type_or_base, default=_missing, sensitive=_missing,
     return util.InnerClassMeta('Knob', (type_or_base,), class_dict)
 
 
+def Knob(type_or_base, default=_missing, sensitive=_missing,
+         deprecated=_missing, description=_missing, cli_positional=_missing,
+         cli_name=_missing, cli_short_name=_missing, cli_aliases=_missing,
+         cli_metavar=_missing):
+    return knob(type_or_base,
+                default=default,
+                sensitive=sensitive,
+                deprecated=deprecated,
+                description=description,
+                cli_positional=cli_positional,
+                cli_name=cli_name,
+                cli_short_name=cli_short_name,
+                cli_aliases=cli_aliases,
+                cli_metavar=cli_metavar)
+
+
 class Configurable(six.with_metaclass(abc.ABCMeta, object)):
     """
     Base class of all configurables.