From 99ea326b1cbdbcc52c6bdf49cf59e83dcd7f7cfa Mon Sep 17 00:00:00 2001
From: Rob Crittenden <rcritten@redhat.com>
Date: Jan 15 2021 09:01:28 +0000
Subject: ipa_pwd: Remove unnecessary conditional


It is already confirmed that item_data is not NULL so there
is no need to check it again.

Discovered by coverity.

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Reviewed-By: Robbie Harwood <rharwood@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>

---

diff --git a/util/ipa_pwd.c b/util/ipa_pwd.c
index 8fa413c..2abc9d2 100644
--- a/util/ipa_pwd.c
+++ b/util/ipa_pwd.c
@@ -312,9 +312,6 @@ static int ipapwd_cmp_password(char *password, char *historyString)
     }
 
     size_t item_len = EVP_DecodeBlock(item_data, (unsigned char *) b64part, b64_len);
-    if (!item_data) {
-        return -1;
-    }
     if (item_len <= SHA_SALT_LENGTH) {
         ret = -1;
         goto done;