From 8c38c57f77a455d6e5c257d4397011157f4f33e3 Mon Sep 17 00:00:00 2001
From: Stanislav Levin <slev@altlinux.org>
Date: Mar 29 2021 10:55:19 +0000
Subject: Azure: Run rpmlint on Fedora


Template the autoconf phase.

Fixes: https://pagure.io/freeipa/issue/8768
Signed-off-by: Stanislav Levin <slev@altlinux.org>
Reviewed-By: Rob Crittenden <rcritten@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>

---

diff --git a/freeipa.spec.in b/freeipa.spec.in
index cfa7bc7..7a665e0 100755
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -49,9 +49,9 @@
 # lint is not executed during rpmbuild
 # %%global with_lint 1
 %if %{with lint}
-    %global linter_options --enable-pylint --with-jslint
+    %global linter_options --enable-pylint --with-jslint --enable-rpmlint
 %else
-    %global linter_options --disable-pylint --without-jslint
+    %global linter_options --disable-pylint --without-jslint --disable-rpmlint
 %endif
 
 # Include SELinux subpackage
diff --git a/ipatests/azure/azure-pipelines.yml b/ipatests/azure/azure-pipelines.yml
index e90f37e..3367b76 100644
--- a/ipatests/azure/azure-pipelines.yml
+++ b/ipatests/azure/azure-pipelines.yml
@@ -19,11 +19,7 @@ jobs:
     options: --cap-add=SYS_PTRACE --security-opt seccomp=unconfined --privileged --env container=docker
   steps:
     - template: templates/${{ variables.PREPARE_BUILD_TEMPLATE }}
-    - script: |
-        set -e
-        echo "Running autoconf generator"
-        ./autogen.sh
-      displayName: Configure the project
+    - template: templates/${{ variables.AUTOCONF_TEMPLATE }}
     - script: |
         set -e
         git update-ref refs/heads/$(System.PullRequest.TargetBranch) origin/$(System.PullRequest.TargetBranch)
@@ -70,11 +66,7 @@ jobs:
     options: --cap-add=SYS_PTRACE --security-opt seccomp=unconfined --privileged --env container=docker
   steps:
     - template: templates/${{ variables.PREPARE_BUILD_TEMPLATE }}
-    - script: |
-        set -e
-        echo "Running autoconf generator"
-        ./autogen.sh
-      displayName: Configure the project
+    - template: templates/${{ variables.AUTOCONF_TEMPLATE }}
     - script: |
         set -e
         echo "Running make target 'lint'"
@@ -119,11 +111,7 @@ jobs:
   steps:
     - template: templates/${{ variables.PREPARE_BUILD_TEMPLATE }}
     - template: templates/${{ variables.PREPARE_WEBUI_TEMPLATE }}
-    - script: |
-        set -e
-        echo "Running autoconf generator"
-        ./autogen.sh
-      displayName: Configure the project
+    - template: templates/${{ variables.AUTOCONF_TEMPLATE }}
     - script: |
         set -e
         echo "Running WebUI unit tests"
diff --git a/ipatests/azure/templates/autoconf-fedora.yml b/ipatests/azure/templates/autoconf-fedora.yml
new file mode 100644
index 0000000..df820e4
--- /dev/null
+++ b/ipatests/azure/templates/autoconf-fedora.yml
@@ -0,0 +1,12 @@
+parameters:
+    options: ''
+
+steps:
+- script: |
+    set -e
+    echo "Running autoconf generator"
+    ./autogen.sh \
+        ${{ parameters.options }} \
+        --enable-rpmlint \
+
+  displayName: Configure the project
diff --git a/ipatests/azure/templates/variables-fedora.yml b/ipatests/azure/templates/variables-fedora.yml
index 3e8f878..133a4a1 100644
--- a/ipatests/azure/templates/variables-fedora.yml
+++ b/ipatests/azure/templates/variables-fedora.yml
@@ -6,6 +6,9 @@ variables:
   # the Dockerfile to build Docker image for running IPA tests
   DOCKER_DOCKERFILE: ${{ format('Dockerfile.build.{0}', variables.IPA_PLATFORM) }}
 
+  # the template to autoconf the project
+  AUTOCONF_TEMPLATE: ${{ format('autoconf-{0}.yml', variables.IPA_PLATFORM) }}
+
   # the template to install IPA's buildtime dependencies
   PREPARE_BUILD_TEMPLATE: ${{ format('prepare-build-{0}.yml', variables.IPA_PLATFORM) }}
 
diff --git a/ipatests/azure/templates/variables-rawhide.yml b/ipatests/azure/templates/variables-rawhide.yml
index 6cbc78d..3fb0cdd 100644
--- a/ipatests/azure/templates/variables-rawhide.yml
+++ b/ipatests/azure/templates/variables-rawhide.yml
@@ -9,6 +9,9 @@ variables:
   # the Dockerfile to build Docker image for running IPA tests
   DOCKER_DOCKERFILE: 'Dockerfile.build.rawhide'
 
+  # the template to autoconf the project
+  AUTOCONF_TEMPLATE: ${{ format('autoconf-{0}.yml', variables.IPA_PLATFORM) }}
+
   # the template to install IPA's buildtime dependencies
   PREPARE_BUILD_TEMPLATE: ${{ format('prepare-build-{0}.yml', variables.IPA_PLATFORM) }}