From 8b7bb96b327207284c8c0a45cf2979843482cf48 Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Mar 25 2020 13:47:12 +0000 Subject: Don't save password history on non-Kerberos accounts While other password policies were properly ignored the password history was always being saved if the global history size was non-zero. Reviewed-By: Christian Heimes --- diff --git a/daemons/ipa-slapi-plugins/ipa-pwd-extop/common.c b/daemons/ipa-slapi-plugins/ipa-pwd-extop/common.c index 60dfe1b..ba5c54e 100644 --- a/daemons/ipa-slapi-plugins/ipa-pwd-extop/common.c +++ b/daemons/ipa-slapi-plugins/ipa-pwd-extop/common.c @@ -888,8 +888,8 @@ int ipapwd_SetPassword(struct ipapwd_krbcfg *krbcfg, slapi_mods_add_string(smods, LDAP_MOD_REPLACE, "userPassword", data->password); - /* set password history */ - if (data->policy.history_length > 0) { + /* set password history if a Kerberos object */ + if (data->policy.history_length > 0 && is_krb) { pwvals = ipapwd_setPasswordHistory(smods, data); if (pwvals) { slapi_mods_add_mod_values(smods, LDAP_MOD_REPLACE,