From 82266c0d00a3c53eb782d6ca99a4872fa09b1b00 Mon Sep 17 00:00:00 2001
From: Simo Sorce <ssorce@redhat.com>
Date: Jan 11 2012 17:04:15 +0000
Subject: Fix CID 11019: Resource leak


https://fedorahosted.org/freeipa/ticket/2037

---

diff --git a/daemons/ipa-kdb/ipa_kdb.c b/daemons/ipa-kdb/ipa_kdb.c
index 6a6c206..481b1f3 100644
--- a/daemons/ipa-kdb/ipa_kdb.c
+++ b/daemons/ipa-kdb/ipa_kdb.c
@@ -263,6 +263,13 @@ int ipadb_get_connection(struct ipadb_context *ipactx)
 
 done:
     ldap_msgfree(res);
+
+    ldap_value_free_len(vals);
+    for (i = 0; i < c && cvals[i]; i++) {
+        free(cvals[i]);
+    }
+    free(cvals);
+
     if (ret) {
         if (ipactx->lcontext) {
             ldap_unbind_ext_s(ipactx->lcontext, NULL, NULL);
@@ -274,12 +281,6 @@ done:
         return EIO;
     }
 
-    ldap_value_free_len(vals);
-    for (i = 0; i < c; i++) {
-        free(cvals[i]);
-    }
-    free(cvals);
-
     return 0;
 }